Skip to content
This repository was archived by the owner on Oct 28, 2022. It is now read-only.

Conversation

@mikachan
Copy link
Member

@mikachan mikachan commented Oct 7, 2022

This PR improves the pullquote block styles:

  • Applies small font size to citation
  • Adds top and bottom border
  • Applies 1.3 line-height
  • Adds top and bottom margin using the var(--wp--preset--spacing--40) preset

image

Closes #263.

@mikachan mikachan requested a review from beafialho October 7, 2022 14:20
@beafialho
Copy link
Collaborator

Thank you @mikachan! I have only two comments:

  • In the front end, everything looks ok but citation should not be Italic, it should be Regular

Captura de ecrã 2022-10-07, às 15 37 19

  • In the editor, the citation is appearing all caps (it should not be)

Captura de ecrã 2022-10-07, às 15 34 11

@mikachan
Copy link
Member Author

mikachan commented Oct 7, 2022

Thanks for taking a look! These two things should be fixed now. I've also improved the citation styles for the quote block, so they're the same as the pullquote.

I had a go at improving the default quote appearance too. I can't seem to improve the border, as the border should change with the quote alignment (left border for left alignment, right border for right alignment), and we can't control this in theme.json. However, adding padding makes the quote at least look different, while we wait for WordPress/gutenberg#44640 to land:

image

@mikachan mikachan merged commit 28e59be into trunk Oct 10, 2022
@mikachan mikachan deleted the update/quote-blocks branch October 10, 2022 14:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quote & Pullquote: not looking accurate in the editor and front end

3 participants