Skip to content

Conversation

@getdave
Copy link
Contributor

@getdave getdave commented Oct 3, 2025

Backport of WordPress/gutenberg#71630

Trac ticket: https://core.trac.wordpress.org/ticket/64074

Please note that we are aiming to remove the need for this binding as part of WordPress/gutenberg#72165.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@getdave getdave requested a review from ockham October 3, 2025 14:35
@getdave getdave self-assigned this Oct 3, 2025
@getdave getdave changed the title Add new binding Backport new entity block binding binding Oct 3, 2025
@github-actions
Copy link

github-actions bot commented Oct 3, 2025

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Comment on lines +52 to +54
if ( is_wp_error( $permalink ) ) {
return null;
}
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The get_permalink() return either string or bool false why we check is_wp_error here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's just an error on my part which we need to fix.

@leoseekoon
Copy link

Thanks Changes look good
{{{
#!html

}}}.

@getdave
Copy link
Contributor Author

getdave commented Oct 17, 2025

As we have now refactored the implementation to use the existing Post and Term bindings there is no need for a backport. Closing this one out.

cc @ockham

@getdave getdave closed this Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants