Skip to content

HTML API: Double escape character refs when setting attribute values #10143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sirreal wants to merge 13 commits into from
Closed

HTML API: Double escape character refs when setting attribute values #10143

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8d8622e
Layout ternary on multiple lines
sirreal Oct 3, 2025
8e0d406
Escape with htmlspecialchars
sirreal Oct 3, 2025
66af901
Add test
sirreal Oct 3, 2025
ff62be1
Use assertEqualHTML for legible test output
sirreal Oct 3, 2025
daef88f
Update two tests for no-double-encode behavior
sirreal Oct 3, 2025
c2e2ad4
Update tests
sirreal Oct 3, 2025
5e5473a
Update block supports tests
sirreal Oct 3, 2025
40cfce5
Merge branch 'trunk' into trac-64054
sirreal Oct 8, 2025
1435b6e
Update escaping function to use simple strtr()
sirreal Oct 8, 2025
b581113
Update comment about attribute value escaping
sirreal Oct 8, 2025
0db1374
Improve function description following review suggestion.
sirreal Oct 9, 2025
605b00d
Fix typo in comment, expand examples, and copy to HTML Processor.
dmsnell Oct 9, 2025
00f01bf
Moar text fixes
dmsnell Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update comment about attribute value escaping
  • Loading branch information
@sirreal
sirreal committed Oct 8, 2025
commit b581113d08805a8924b9d7dd82d9fce053161a03
3 changes: 2 additions & 1 deletion src/wp-includes/html-api/class-wp-html-tag-processor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3884,7 +3884,8 @@ static function ( $tag_match ) {
* - When `true` is passed as the value, then only the attribute name is added to the tag.
* - When `false` is passed, the attribute gets removed if it existed before.
*
* For string attributes, the value is escaped using the `esc_attr` function.
* HTML escaping will be performed for string attribute values. The input value should
* not be unescaped.
Copy link
Member

@dmsnell dmsnell Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a confusing double-negative here.
can we rearrange this so it’s a positive indication of what to do, rather than a negative impression of what not to do?

 * This function handles all HTML escaping: send normal and unescaped string values.
 * The HTML API will convey input strings such that a browser will read the decoded
 * string values as verbatim copies to what is provided here.
 *
 * Example:
 *
 *     // Renders “Eggs & Milk” in a browser, encoded as “Eggs & Milk”.
 *     $processor->set_attribute( 'title', 'Eggs & Milk' );
 *
 *     // Renders “Eggs & Milk” in a browser, encoded as “Eggs & Milk”.
 *     $processor->set_attribute( 'title', 'Eggs & Milk' );

Copy link
Member Author

@sirreal sirreal Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated the description in 0db1374, happy to make further adjustments.

*
* @since 6.2.0
* @since 6.2.1 Fix: Only create a single update for multiple calls with case-variant attribute names.
Expand Down
Loading