Skip to content

Fix potential fatal error on Interactivity API processing directives #10485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
samueljseay wants to merge 4 commits into from
Closed

Fix potential fatal error on Interactivity API processing directives #10485

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aedb36e
fix potential fatal error on Interactivity API processing directives …
hugosolar Aug 27, 2025
3ab520d
Run logic when is null
DAreRodz Nov 7, 2025
9081c19
Add supporting test for the malformed br case.
samueljseay Nov 7, 2025
917c95e
Merge remote-tracking branch 'origin/trunk' into feature/add-on-to-pr…
samueljseay Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Run logic when is null
  • Loading branch information
@DAreRodz @samueljseay
DAreRodz authored and samueljseay committed Nov 7, 2025
commit 3ab520d8384a03d3eabb60ec9ec2401efd6eab92
4 changes: 2 additions & 2 deletions src/wp-includes/interactivity-api/class-wp-interactivity-api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,11 +521,11 @@ private function _process_directives( string $html ) {
}
} else {
$each_child_attrs = $p->get_attribute_names_with_prefix( 'data-wp-each-child' );
if ( ! is_countable( $each_child_attrs ) ) {
if ( null === $each_child_attrs ) {
continue;
}

if ( 0 !== count( $each_child_attrs ) ) {
if ( null !== $each_child_attrs && 0 !== count( $each_child_attrs ) ) {
/*
* If the tag has a `data-wp-each-child` directive, jump to its closer
* tag because those tags have already been processed.
Expand Down