Skip to content

HTML API: Ensure correct encoding of modified class names #10591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sirreal wants to merge 4 commits into from
+52 −6
Closed

HTML API: Ensure correct encoding of modified class names #10591

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c8756b
Add failing test for ticket 64340
sirreal Dec 3, 2025
cf42da8
Include correctly encoded HTML class name "&" initially
sirreal Dec 3, 2025
135f3dd
Add missing attribute decode when accessing raw class attribute HTML
sirreal Dec 3, 2025
99d7043
Update tests enforcing double-encoding
sirreal Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update tests enforcing double-encoding
  • Loading branch information
@sirreal
sirreal committed Dec 3, 2025
commit 99d7043cac8bed796935e10b479091115fe17554
4 changes: 2 additions & 2 deletions tests/phpunit/tests/html-api/wpHtmlTagProcessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2887,11 +2887,11 @@ public static function data_updating_attributes_in_malformed_html() {
),
'HTML tag opening inside attribute value' => array(
'input' => '<pre id="<code" class="wp-block-code <code is poetry&gt;"><code>This &lt;is> a &lt;strong is="true">thing.</code></pre><span>test</span>',
'expected' => '<pre foo="bar" id="<code" class="wp-block-code &lt;code is poetry&amp;gt; firstTag"><code class="secondTag">This &lt;is> a &lt;strong is="true">thing.</code></pre><span>test</span>',
'expected' => '<pre foo="bar" id="<code" class="wp-block-code &lt;code is poetry&gt; firstTag"><code class="secondTag">This &lt;is> a &lt;strong is="true">thing.</code></pre><span>test</span>',
),
'HTML tag brackets in attribute values and data markup' => array(
'input' => '<pre id="<code-&gt;-block-&gt;" class="wp-block-code <code is poetry&gt;"><code>This &lt;is> a &lt;strong is="true">thing.</code></pre><span>test</span>',
'expected' => '<pre foo="bar" id="<code-&gt;-block-&gt;" class="wp-block-code &lt;code is poetry&amp;gt; firstTag"><code class="secondTag">This &lt;is> a &lt;strong is="true">thing.</code></pre><span>test</span>',
'expected' => '<pre foo="bar" id="<code-&gt;-block-&gt;" class="wp-block-code &lt;code is poetry&gt; firstTag"><code class="secondTag">This &lt;is> a &lt;strong is="true">thing.</code></pre><span>test</span>',
Comment on lines +2890 to +2894
Copy link
Member Author

@sirreal sirreal Dec 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests seem to have been ensuring incorrect behavior.

In both cases updated here an input class like poetry&gt; (decoded value poetry>) was changed to poetry&amp;gt; (decoded value poetry&gt;).

They were updated in #10143. This change restores their original (correct) assertion.

),
'Single and double quotes in attribute value' => array(
'input' => '<p title="Demonstrating how to use single quote (\') and double quote (&quot;)"><span>test</span>',
Expand Down
Loading