Skip to content

Merge conflicting wp.editor objects into a single, non-conflicting module #1481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adamziel wants to merge 3 commits into from
Closed

Merge conflicting wp.editor objects into a single, non-conflicting module #1481

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8b991ea
Assign window.wp.oldEditor properties to window.wp.editor
adamziel Jul 7, 2021
b9f57cf
remove dev artifact
adamziel Jul 7, 2021
5008797
Update src/wp-includes/script-loader.php
adamziel Jul 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Assign window.wp.oldEditor properties to window.wp.editor
  • Loading branch information
@adamziel
adamziel committed Jul 7, 2021
commit 8b991ea860270e9db61ccac877522e80f284473f
12 changes: 11 additions & 1 deletion src/wp-includes/script-loader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
/** WordPress Styles Class */
require ABSPATH . WPINC . '/class.wp-styles.php';

/** WordPress Styles Functions */
/** WordPress Styles Function */
require ABSPATH . WPINC . '/functions.wp-styles.php';

/**
Expand Down Expand Up @@ -381,6 +381,16 @@ function wp_default_packages_inline_scripts( $scripts ) {
'window.wp.oldEditor = window.wp.editor;',
'after'
);

// wp-editor module is exposed as window.wp.editor
// Problem: there is quite some code expecting window.wp.oldEditor object available under window.wp.editor
// Solution: fuse the two objects together to maintain backward compatibility
// For more context, see https://github.com/WordPress/gutenberg/issues/33203
$scripts->add_inline_script(
'wp-editor',
'Object.assign(window.wp.editor, window.wp.oldEditor);',
'after'
);
}

/**
Expand Down