Conditionally load registered block-styles depending on wp_should_load_separate_core_block_assets #1482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
reviewed
Jul 12, 2021
gziolo
reviewed
Jul 12, 2021
gziolo
approved these changes
Jul 12, 2021
Member
gziolo
left a comment
gziolo
left a comment
There was a problem hiding this comment.
This is a really nice enhancement. Thank you for working on it. I left two minor notes to discuss. Let's include those changes in WP 5.9 💯
Member
|
Committed in https://core.trac.wordpress.org/changeset/51471. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
enqueue_block_styles_assetsfunction, adding conditions forwp_should_load_separate_core_block_assets()and making sure that registered block-styles only load when a block gets rendered on a page.Trac ticket: https://core.trac.wordpress.org/ticket/53616
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.