Code Modernization: Silence the deprecation warning for missing return type in src/wp-includes/Requests/Utility/CaseInsensitiveDictionary.php
#1799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n type in `src/wp-includes/Requests/Utility/CaseInsensitiveDictionary.php` This fixes the "Deprecated: Return type of `Requests_Utility_CaseInsensitiveDictionary::offsetExists()` should be compatible with `ArrayAccess::offsetExists(): bool`" and similar warnings on PHP 8.1. PHP native interfaces now have declared return types and methods in classes implementing these interfaces need to either have the return type declared (in a covariant compatible manner with the PHP native interface method declaration), or need to silence the deprecation warning using the `#[ReturnTypeWillChange]` attribute. Trac ticket: https://core.trac.wordpress.org/ticket/53635
Contributor
|
Hello @anomiex and thank you for your contribution. The fixes in this PR are for an external library, i.e. Requests. Fixes for this library should be made in its repo https://github.com/wordpress/requests and not in Core itself. Once Requests releases a new version, then Core will be updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the "Deprecated: Return type of
Requests_Utility_CaseInsensitiveDictionary::offsetExists()should be compatible withArrayAccess::offsetExists(): bool" and similar warnings on PHP 8.1.PHP native interfaces now have declared return types and methods in classes implementing these interfaces need to either have the return type declared (in a covariant compatible manner with the PHP native interface method declaration), or need to silence the deprecation warning using the
#[ReturnTypeWillChange]attribute.Trac ticket: https://core.trac.wordpress.org/ticket/53635
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.