Skip to content

Copy navigation area infrastructure from Gutenberg #1865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
noisysocks wants to merge 17 commits into from
Closed

Copy navigation area infrastructure from Gutenberg #1865

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
5dcb11e
Copy navigation area infrastructure from Gutenberg
noisysocks Nov 11, 2021
8526afb
Fix _disable_block_editor_for_navigation_post_type args
noisysocks Nov 11, 2021
d46eb50
Preload /wp/v2/block-navigation-areas, not __experimental/block-navig…
noisysocks Nov 12, 2021
3e60e6e
Rename fse_navigation_areas -> wp_navigation_areas
noisysocks Nov 12, 2021
c3b9d2d
Use add_query_args()
noisysocks Nov 12, 2021
d686a6f
Use _wp_ prefix
noisysocks Nov 12, 2021
86d97ef
Add types to _wp_migrate_menu_to_navigation_post
noisysocks Nov 12, 2021
696c320
Remove unnecessary array cast
noisysocks Nov 12, 2021
7449d66
Remove ternary
noisysocks Nov 12, 2021
9513276
Use all_items instead of menu_name
noisysocks Nov 12, 2021
176164e
Query only IDs
noisysocks Nov 12, 2021
14ffacc
Use empty()
noisysocks Nov 12, 2021
6d974ce
Remove unnecessary variable
noisysocks Nov 12, 2021
07379cf
Set priority to 99, not 200
noisysocks Nov 12, 2021
1799e29
Revert "Rename fse_navigation_areas -> wp_navigation_areas"
noisysocks Nov 12, 2021
5ca5336
Disable post attributes for wp_navigation CPT
noisysocks Nov 12, 2021
49d8b87
Add test fixtures
noisysocks Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use empty()
  • Loading branch information
@noisysocks
noisysocks committed Nov 12, 2021
commit 14ffacc2353e3b7734eed0f4bc8a7e012d60a04e
2 changes: 1 addition & 1 deletion src/wp-includes/navigation-areas.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ function _wp_migrate_menu_to_navigation_post( $new_name, WP_Theme $new_theme, WP
)
);

if ( count( $matching_posts ) ) {
if ( ! empty( $matching_posts ) ) {
$navigation_post_id = $matching_posts[0]->ID;
} else {
$menu_items_by_parent_id = _wp_sort_menu_items_by_parent_id( $menu_items );
Expand Down