Tweaks and add comments.

src/wp-includes/rest-api/endpoints/class-wp-rest-edit-site-export-controller.php

@@ -17,15 +17,19 @@
 class WP_REST_Edit_Site_Export_Controller extends WP_REST_Controller {
 
 	/**
-	 * Constructs the controller.
+	 * Constructor.
+	 *
+	 * @since 5.9.0
 	 */
 	public function __construct() {
 		$this->namespace = 'wp-block-editor/v1';
 		$this->rest_base = 'export';
 	}
 
 	/**
-	 * Registers the necessary REST API routes.
+	 * Registers the site export route.
+	 *
+	 * @since 5.9.0
 	 */
 	public function register_routes() {
 		register_rest_route(
@@ -44,31 +48,37 @@ public function register_routes() {
 	/**
 	 * Checks whether a given request has permission to export.
 	 *
-	 * @return WP_Error|bool True if the request has access, or WP_Error object.
+	 * @since 5.9.0
+	 *
+	 * @return WP_Error|true True if the request has access, or WP_Error object.
 	 */
 	public function permissions_check() {
-		if ( current_user_can( 'edit_theme_options' ) ) {
-			return true;
+		if ( ! current_user_can( 'edit_theme_options' ) ) {
+			new WP_Error(
+				'rest_cannot_view_url_details',
+				__( 'Sorry, you are not allowed to export templates and template parts.' ),
+				array( 'status' => rest_authorization_required_code() )
+			);
 		}
 
-		return new WP_Error(
-			'rest_cannot_view_url_details',
-			__( 'Sorry, you are not allowed to export templates and template parts.' ),
-			array( 'status' => rest_authorization_required_code() )
-		);
+		return true;
 	}
 
 	/**
 	 * Output a ZIP file with an export of the current templates
 	 * and template parts from the site editor, and close the connection.
 	 *
+	 * @since 5.9.0
+	 *
 	 * @return WP_Error|void
 	 */
 	public function export() {
 		// Generate the export file.
 		$filename = wp_generate_block_templates_export_file();
 
 		if ( is_wp_error( $filename ) ) {
+			$filename->add_data( array( 'status' => 500 ) );
+
 			return $filename;
 		}
 

tests/phpunit/tests/block-template-utils.php

@@ -346,6 +346,8 @@ function test_flatten_blocks() {
 
 	/**
 	 * Should generate block templates export file.
+	 *
+	 * @ticket 54448
 	 */
 	function test_wp_generate_block_templates_export_file() {
 		$filename = wp_generate_block_templates_export_file();