-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Generate global styles body reset rule prior to processes theme.json #1989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate global styles body reset rule prior to processes theme.json #1989
Conversation
|
Hi @getdave! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
Committed via https://core.trac.wordpress.org/changeset/52329. |
…es precedence (#36960) * Set default margin on body prior to generating styles from theme.json * Add additional context to comment Addresses #36960 (comment) * Restore simple version of body rule Also avoids creating failing unit tests due to a single space character changing in a snaphshot! * Update with fixes made in Core patch See WordPress/wordpress-develop#1989 * Fix output now includes new line. * Fix tests relating to spacing * Fix test to put body CSS reset first
…es precedence (#36960) * Set default margin on body prior to generating styles from theme.json * Add additional context to comment Addresses #36960 (comment) * Restore simple version of body rule Also avoids creating failing unit tests due to a single space character changing in a snaphshot! * Update with fixes made in Core patch See WordPress/wordpress-develop#1989 * Fix output now includes new line. * Fix tests relating to spacing * Fix test to put body CSS reset first
Companion fix to WordPress/gutenberg#36960.
In WordPress/gutenberg#36147 we learn that the Theme JSON class automatically applies a
margin: 0to thebodyelement. Unfortunately it does so in a way that means if you usetheme.jsonto define a margin on the body element, the defaultmargin: 0will still take precedence.For example applying this to
theme.jsonwill still leave you with the defaultmargin: 0on thebody, rather than the expected value ofmargin: 0 5rem:This PR fixes this by only applying the default
margin: 0if the root spacing does not have a margin declaration.Trac ticket: https://core.trac.wordpress.org/ticket/54550
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.