Make ?_wp-find-template=true work for new posts
#1997
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
commented
Dec 2, 2021
Contributor
Author
|
cc/ @carolinan since you reported WordPress/gutenberg#36986 🙂 |
noisysocks
reviewed
Dec 3, 2021
Co-authored-by: Robert Anderson <[email protected]>
Relocated to `wp-includes/default-filters.php`.
Contributor
Author
|
Thanks a lot @hellofromtonya and @noisysocks for reviewing and polishing! ❤️ |
Contributor
|
Committed via https://core.trac.wordpress.org/changeset/52316. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Originally reported in WordPress/gutenberg#36986.
If you create a new post (Posts → Add New) and open the Network tab in DevTools you'll see a request made to
?_wp-find-template=truewith a 404 error.This causes some unexpected behaviour in the post editor, described in the issue above.
As @noisysocks correctly suspected in https://core.trac.wordpress.org/ticket/54553, this is because of a missing filter that calls
locate_block_templateuponwp_loaded.The fix is to basically backport WordPress/gutenberg#32442, which only made it into Gutenberg briefly after the custom block templates for pages infrastructure was backported to Core (#1267).
Testing instructions
Verify that WordPress/gutenberg#36986 is fixed.
Potential Follow-up
It'd be nice if we could add some test coverage for this, e.g. a test that
GETs/?p=123&_wp-find-template=true(where123is the ID of a new auto-draft). Not sure if there's prior art for this, so it could be a bit complex to do.Trac ticket: https://core.trac.wordpress.org/ticket/54553
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.