Skip to content

KSES: allow port numbers in pdf object url #1998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ramonjd wants to merge 15 commits into from
Closed

KSES: allow port numbers in pdf object url #1998

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
1adfc1b
Initial commit.
ramonjd Dec 2, 2021
5831115
Oh linter! How sweet thy plaintiff missives be to mine ears
ramonjd Dec 2, 2021
c7de626
Checking for the existence of the index port
ramonjd Dec 2, 2021
eb8fa69
Checking for the existence of the index host
ramonjd Dec 2, 2021
7ae4c78
Creating a new test + data provider and a filter to add a port number…
ramonjd Dec 2, 2021
9dcfa81
Removed dupe test
ramonjd Dec 2, 2021
306471d
Made comment readable
ramonjd Dec 2, 2021
bf474cf
Update tests/phpunit/tests/kses.php
ramonjd Dec 3, 2021
53d007f
Update tests/phpunit/tests/kses.php
ramonjd Dec 3, 2021
872e96a
Relocated test where the url didn't contain a port
ramonjd Dec 3, 2021
af59eee
'port' does not exist as an index on the $param array. It would help …
ramonjd Dec 3, 2021
4a2988a
Linter! My friend, why do you forsake me? You run so slowly on my loc…
ramonjd Dec 3, 2021
7d44da3
Unhappy paths
ramonjd Dec 3, 2021
eaa4e5b
My blod is typo
ramonjd Dec 3, 2021
ef96bcc
My blod is typo
ramonjd Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
My blod is typo
  • Loading branch information
@ramonjd
ramonjd committed Dec 3, 2021
commit eaa4e5b037a85cd21effff1b31dc8fed52e6ea3f
2 changes: 1 addition & 1 deletion tests/phpunit/tests/kses.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1635,7 +1635,7 @@ function data_wp_kses_object_data_url_with_port_number_allowed() {
'<object type="application/pdf" data="http://example.org:3333/cat/foo.pdf" />',
'',
),
'url with without protocol' => array(
'url without protocol' => array(
'<object type="application/pdf" data="http://example.org/cat/foo.pdf" />',
'',
),
Expand Down