Fix 54790 #2138
Closed
Fix 54790 #2138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param array $block The full block, including name and attributes. | ||
| * @return string Block content. | ||
| */ | ||
| $callback_separate = static function( $content, $block ) use ( $block_name, $callback ) { |
Contributor
There was a problem hiding this comment.
Anonymous functions as callbacks to filter/action is prohibited in Core.
To resolve, an overall architectural strategy is needed to provide the means to unhook callbacks and remove the anonymous functions.
However, as this pattern already exists in this file and it's too late in 5.9 to introduce a new architectural strategy to remove the need for these lambdas, this pattern is consistent. Plus the static keyword is for performance.
hellofromtonya
approved these changes
Jan 11, 2022
Contributor
hellofromtonya
left a comment
hellofromtonya
left a comment
There was a problem hiding this comment.
Ready for commit 👍
Contributor
|
Committed via https://core.trac.wordpress.org/changeset/52556. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a block theme, make sure that additional block styles enqueued using
wp_enqueue_block_styleonly get printed when the block exists on the page.Trac ticket: https://core.trac.wordpress.org/ticket/54790
Backports Gutenberg patch from WordPress/gutenberg#37848
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.