Skip to content

Add caching to comment feeds #2181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spacedmonkey wants to merge 1 commit into from
Closed

Add caching to comment feeds #2181

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 42 additions & 8 deletions src/wp-includes/class-wp-query.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2720,10 +2720,28 @@ public function get_posts() {
$corderby = ( ! empty( $corderby ) ) ? 'ORDER BY ' . $corderby : '';
$climits = ( ! empty( $climits ) ) ? $climits : '';

$comments = (array) $wpdb->get_results( "SELECT $distinct {$wpdb->comments}.* FROM {$wpdb->comments} $cjoin $cwhere $cgroupby $corderby $climits" );
// Convert to WP_Comment.
/** @var WP_Comment[] */
$this->comments = array_map( 'get_comment', $comments );
$comments_request = "SELECT $distinct {$wpdb->comments}.* FROM {$wpdb->comments} $cjoin $cwhere $cgroupby $corderby $climits";

$key = md5( $comments_request );
$last_changed = wp_cache_get_last_changed( 'comment' ) . wp_cache_get_last_changed( 'posts' );

$cache_key = "comment_feed:$key:$last_changed";
$comment_ids = wp_cache_get( $cache_key, 'comment' );
if ( ! $comment_ids ) {
$comments = (array) $wpdb->get_results( $comments_request );
// Convert to WP_Comment.
/** @var WP_Comment[] */
$comments = array_map( 'get_comment', $comments );
$comment_ids = wp_list_pluck( $comments, 'comment_ID' );
wp_cache_add( $cache_key, $comment_ids, 'comment' );
} else {
_prime_comment_caches( $comment_ids, false );
// Convert to WP_Comment.
/** @var WP_Comment[] */
$comments = array_map( 'get_comment', $comment_ids );
}

$this->comments = $comments;
$this->comment_count = count( $this->comments );

$post_ids = array();
Expand Down Expand Up @@ -3150,10 +3168,26 @@ public function get_posts() {
$climits = apply_filters_ref_array( 'comment_feed_limits', array( 'LIMIT ' . get_option( 'posts_per_rss' ), &$this ) );

$comments_request = "SELECT {$wpdb->comments}.* FROM {$wpdb->comments} $cjoin $cwhere $cgroupby $corderby $climits";
$comments = $wpdb->get_results( $comments_request );
// Convert to WP_Comment.
/** @var WP_Comment[] */
$this->comments = array_map( 'get_comment', $comments );
$key = md5( $comments_request );
$last_changed = wp_cache_get_last_changed( 'comment' );

$cache_key = "comment_feed:$key:$last_changed";
$comment_ids = wp_cache_get( $cache_key, 'comment' );
if ( ! $comment_ids ) {
$comments = (array) $wpdb->get_results( $comments_request );
// Convert to WP_Comment.
/** @var WP_Comment[] */
$comments = array_map( 'get_comment', $comments );
$comment_ids = wp_list_pluck( $comments, 'comment_ID' );
wp_cache_add( $cache_key, $comment_ids, 'comment' );
} else {
_prime_comment_caches( $comment_ids, false );
// Convert to WP_Comment.
/** @var WP_Comment[] */
$comments = array_map( 'get_comment', $comment_ids );
}

$this->comments = $comments;
$this->comment_count = count( $this->comments );
}

Expand Down