Update @wordpress packages #2184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
For the most part this is working well, but the issue behind WordPress/gutenberg#38019 doesn't seem to be fixed in testing this branch.
Member
Author
|
Thanks for testing! If I follow the steps in WordPress/gutenberg#37708 I can't repro the issue. I also don't see |
tellthemachines
approved these changes
Jan 18, 2022
Contributor
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
Re-running the build seems to have fixed the issue ✅
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update packages to include these bug fixes from Gutenberg:
SelectControl: mark thechildrenprop as optional gutenberg#37872Trac ticket: https://core.trac.wordpress.org/ticket/54487
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.