Fix Windows paths resulting from get_attached_file.
#2442
Conversation
costdev
left a comment
costdev
left a comment
There was a problem hiding this comment.
Just one suggestion to use a data provider for the new test method.
| /** | ||
| * @ticket 36308 | ||
| */ | ||
| public function test_get_attached_file_with_windows_paths() { |
There was a problem hiding this comment.
Using a data provider for the file, expected values, and possibly the message value, will ensure that both assertions run even if one happens to fail, and makes it easier to add more tests for this in future if needed.
johnbillion
left a comment
johnbillion
left a comment
There was a problem hiding this comment.
This looks good and there's a good amount of test coverage, but I'd also like to see the tests in Tests_Post_GetAttachedFile use a data provider 👍
Hi @johnbillion, see PR 3049 which is a refresh of this PR that uses a data provider in |
|
Closing in favour of #3049 👍 |
4 participants
Trac ticket: https://core.trac.wordpress.org/ticket/36308.