Backport "Migrate post editor editorMode to use preferences store and remove localAutosaveInterval preference #39180" #2523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 tasks
talldan
approved these changes
Apr 7, 2022
Contributor
talldan
left a comment
talldan
left a comment
There was a problem hiding this comment.
LGTM, thanks for handling the backport.
Member
|
Commited with https://core.trac.wordpress.org/changeset/53090. |
| unset( $editor_settings['__experimentalFeatures']['spacing']['padding'] ); | ||
| } | ||
|
|
||
| $editor_settings['localAutosaveInterval'] = 15; |
There was a problem hiding this comment.
Nitpick: it would be nice to move this value (15) to a constant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg plugin migration to WordPress 6.0 also being tracked in WordPress/gutenberg#39889.
This diff moves the localAutosaveInterval editor setting to the preference store introduced in Gutenberg 12.9.0 to WordPress 6.0
Original Pull Request: WordPress/gutenberg#39180
In summary:
Trac ticket: https://core.trac.wordpress.org/ticket/55505
cc @talldan @noisysocks @michalczaplinski who worked on the original Gutenberg PR