Skip to content

Register 'lock' attribute for every block on the server #2615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mamaduka wants to merge 9 commits into from
Closed

Register 'lock' attribute for every block on the server #2615

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b472ad3
Register 'lock' attribute for every block on the server
Mamaduka Apr 21, 2022
3eb1b1d
Remove testing leftovers
Mamaduka Apr 21, 2022
09818fd
Try fixing unit tests
Mamaduka Apr 21, 2022
6b8ff08
Fix lint error
Mamaduka Apr 21, 2022
33343ad
Apply suggestions from code review
gziolo Apr 25, 2022
32dba40
Update tests/phpunit/tests/blocks/wpBlockType.php
gziolo Apr 25, 2022
b5df580
Address feedback
Mamaduka Apr 26, 2022
ae19fc5
Use args
Mamaduka Apr 26, 2022
6f26061
Fix tests
Mamaduka Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Peter Wilson <[email protected]>
  • Loading branch information
@gziolo @peterwilsoncc
gziolo and peterwilsoncc authored Apr 25, 2022
commit 33343ade3aca68ed616b5d9e90d4c30407d32f29
2 changes: 1 addition & 1 deletion tests/phpunit/tests/blocks/wpBlock.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ public function test_constructor_assigns_block_type_from_registry() {
$block = new WP_Block( $parsed_block, $context, $this->registry );

$this->assertInstanceOf( WP_Block_Type::class, $block->block_type );
$this->assertSame(
$this->assertSameSetsWithIndex(
array(
'defaulted' => array(
'type' => 'number',
Expand Down
8 changes: 6 additions & 2 deletions tests/phpunit/tests/blocks/wpBlockType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,14 @@ public function test_set_props() {
$this->assertSame( $args['foo'], $block_type->foo );
}

/*
* @ticket 55567
* @covers WP_Block_Type::set_props
*/
public function test_core_attributes() {
$block_type = new WP_Block_Type( 'core/fake', array() );

$this->assertEquals(
$this->assertSameSetsWithIndex(
array(
'lock' => array( 'type' => 'object' ),
),
Expand All @@ -108,7 +112,7 @@ public function test_core_attributes_matches_custom() {
);

// Backward compatibility: Don't override attributes with the same name.
$this->assertEquals(
$this->assertSameSetsWithIndex(
array(
'lock' => array( 'type' => 'string' ),
),
Expand Down
4 changes: 2 additions & 2 deletions tests/phpunit/tests/rest-api/rest-block-type-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,7 @@ public function test_get_item_invalid() {
$this->assertNull( $data['editor_style'] );
$this->assertNull( $data['style'] );
$this->assertSameSets( array(), $data['provides_context'] );
$this->assertSameSets(
$this->assertSameSetsWithIndex(
array(
'lock' => array( 'type' => 'object' ),
),
Expand Down Expand Up @@ -304,7 +304,7 @@ public function test_get_item_defaults() {
$this->assertNull( $data['view_script'] );
$this->assertNull( $data['editor_style'] );
$this->assertNull( $data['style'] );
$this->assertSameSets(
$this->assertSameSetsWithIndex(
array(
'lock' => array( 'type' => 'object' ),
),
Expand Down