Skip to content

Backport typography block supports for WP 6.1 (refresh) #3237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ironprogrammer wants to merge 18 commits into from
Closed

Backport typography block supports for WP 6.1 (refresh) #3237

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
f704a9e
Changes from:
ramonjd Sep 7, 2022
2f608d2
Standardizing PHP doc comments for tests and new methods.
ramonjd Sep 8, 2022
3e140d2
Formatting
ramonjd Sep 9, 2022
7fa1602
Remove space between attribute and value
ironprogrammer Sep 12, 2022
37ad3e2
Format DocBlock per WP standard
ironprogrammer Sep 12, 2022
eb8c944
Format multiline comment per WP standard
ironprogrammer Sep 12, 2022
d08f8e6
Formatting tweak for DocBlock
ironprogrammer Sep 12, 2022
e889b8d
Formatting adjustment
ironprogrammer Sep 12, 2022
84a9ccd
Format inline comment
ironprogrammer Sep 12, 2022
65c20d3
Remove `@since` for deprecated function
ironprogrammer Sep 12, 2022
aa582ab
Reformat `@deprecated` tag per standards
ironprogrammer Sep 12, 2022
c16d09e
Add `@see` for new function
ironprogrammer Sep 12, 2022
5ff82f6
Remove spaces for typography styles
ironprogrammer Sep 15, 2022
5ad2380
Update deprecation for consistency.
hellofromtonya Sep 20, 2022
2962b3f
Merge branch 'trunk' into add/backport-typography-block-supports-wp-6-1
hellofromtonya Sep 20, 2022
4e99897
Update wp_apply_typography_support() for coding standards
hellofromtonya Sep 20, 2022
c888ae5
Test DocBlock updates for standards
hellofromtonya Sep 20, 2022
09ea58a
Fix failing test - remove empty spaces
hellofromtonya Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove space between attribute and value 
New style engine does not emit spaces between attributes and values.

See #3199.
  • Loading branch information
@ironprogrammer
ironprogrammer committed Sep 14, 2022
commit 7fa16023ab6b23cafcc75c6e2c207392c5094615
4 changes: 2 additions & 2 deletions tests/phpunit/tests/block-supports/typography.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ function test_should_generate_font_family_with_legacy_inline_styles_using_a_valu
$block_atts = array( 'style' => array( 'typography' => array( 'fontFamily' => 'serif' ) ) );

$actual = wp_apply_typography_support( $block_type, $block_atts );
$expected = array( 'style' => 'font-family: serif;' );
$expected = array( 'style' => 'font-family:serif;' );

$this->assertSame( $expected, $actual );
}
Expand Down Expand Up @@ -209,7 +209,7 @@ function test_should_generate_css_var_for_font_family_with_legacy_inline_styles(
$block_atts = array( 'style' => array( 'typography' => array( 'fontFamily' => 'var:preset|font-family|h1' ) ) );

$actual = wp_apply_typography_support( $block_type, $block_atts );
$expected = array( 'style' => 'font-family: var(--wp--preset--font-family--h-1);' );
$expected = array( 'style' => 'font-family:var(--wp--preset--font-family--h-1);' );

$this->assertSame( $expected, $actual );
}
Expand Down