Skip to content

[Backport] Add wp_theme_element_class_name() alias #3244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ockham wants to merge 5 commits into from
Closed

[Backport] Add wp_theme_element_class_name() alias #3244

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e8f5210
[Backport] Add wp_theme_element_class_name() alias
ockham Sep 14, 2022
68ffc05
from -> of
ockham Sep 14, 2022
33f1626
Move since PHPDoc up a bit
ockham Sep 14, 2022
516777b
Remove empty line
ockham Sep 14, 2022
4c85024
Change function name to wp_theme_get_element_class_name
ockham Sep 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[Backport] Add wp_theme_element_class_name() alias
  • Loading branch information
@ockham
ockham committed Sep 14, 2022
commit e8f521066e732f62e240a55690f844003a1beb0a
14 changes: 14 additions & 0 deletions src/wp-includes/theme.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4203,6 +4203,20 @@ function wp_is_block_theme() {
return wp_get_theme()->is_block_theme();
}

/**
* Given an element name, returns a class name.
* Alias from WP_Theme_JSON::get_element_class_name.
*
* @param string $element The name of the element.
*
* @return string The name of the class.
*
* @since 6.1.0
Copy link
Contributor

@costdev costdev Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: @param and @return should come after @since.

*/
function wp_theme_element_class_name( $element ) {
Copy link
Contributor

@costdev costdev Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency with the original method, and for consistent use of the active verb, I'd suggest renaming this alias to wp_theme_get_element_class_name(). 🙂

Copy link
Contributor Author

@ockham ockham Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! That does have a nicer ring to it 😊

Copy link
Contributor Author

@ockham ockham Sep 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

06618d5

return WP_Theme_JSON::get_element_class_name( $element );
}

/**
* Adds default theme supports for block themes when the 'setup_theme' action fires.
*
Expand Down