Skip to content

Feature: Block-based template parts for Classic themes #3258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ockham wants to merge 6 commits into from
Closed

Feature: Block-based template parts for Classic themes #3258

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a8eeca1
Feature: Block-based template parts for Classic themes
Mamaduka Sep 13, 2022
c21592e
Update unit tests
Mamaduka Sep 13, 2022
cfa8c58
fix prevent unwanted access of site-editor.php
fabiankaegy Sep 14, 2022
60cadbd
Bump theme_supports count to 23 in test
ockham Sep 15, 2022
f09fb1f
Updates for Core coding standards
hellofromtonya Sep 15, 2022
c3702ae
Removes extra space for phpcs happiness
hellofromtonya Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix prevent unwanted access of site-editor.php 
non block themes that support block based template parts should only be allowed to access the site-editor.php file if the query parameter to access the template part editor is set correctly
  • Loading branch information
@fabiankaegy @ockham
fabiankaegy authored and ockham committed Sep 15, 2022
commit cfa8c586c5e5e7ea0df5ccb35c193c268d056f5b
5 changes: 5 additions & 0 deletions src/wp-admin/site-editor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@
wp_die( __( 'The theme you are currently using is not compatible with Full Site Editing.' ) );
}

$is_template_part_editor = isset( $_GET['postType'] ) && 'wp_template_part' === sanitize_key( $_GET['postType'] );
if ( ! wp_is_block_theme() && ! $is_template_part_editor ) {
wp_die( __( 'The theme you are currently using is not compatible with the Site Editor.' ) );
}

/**
* Do a server-side redirection if missing `postType` and `postId`
* query args when visiting Site Editor.
Expand Down