Skip to content

(Alternative) Backport script loader: enqueue stored block supports styles (3rd attempt) #3262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewserong wants to merge 8 commits into from
Closed

(Alternative) Backport script loader: enqueue stored block supports styles (3rd attempt) #3262

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0d1bf06
Initial commit.
ramonjd Sep 9, 2022
de2bf55
Added test
ramonjd Sep 9, 2022
7283137
Remove unused global from test
ramonjd Sep 9, 2022
688695c
Formatting
ramonjd Sep 9, 2022
1d4fb6f
Move test
ockham Sep 15, 2022
7d198cb
Remove obsolete PHPDoc
ockham Sep 15, 2022
36bf56f
Update tests so that expected output depends on SCRIPT_DEBUG value
andrewserong Sep 16, 2022
ce07ae8
Fix linting
andrewserong Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Formatting
  • Loading branch information
@ramonjd @andrewserong
ramonjd authored and andrewserong committed Sep 16, 2022
commit 688695c8f7f405561ceaa6efe7970ee5c811d7df
7 changes: 4 additions & 3 deletions tests/phpunit/tests/script-loader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
<?php

/**
* Test functions and classes for widgets and sidebars.
* Tests functions and classes for widgets and sidebars.
*
* @group script-loader
*/
class Tests_Script_Loader extends WP_UnitTestCase {
/**
* Clean up global scope.
* Cleans up global scope.
*
* @global WP_Scripts $wp_scripts
* @global WP_Styles $wp_styles
Expand All @@ -21,6 +21,7 @@ public function clean_up_global_scope() {
* Tests that stored CSS is enqueued.
*
* @ticket 56467
*
* @covers ::wp_enqueue_stored_styles
*/
public function test_should_enqueue_stored_styles() {
Expand All @@ -35,7 +36,7 @@ public function test_should_enqueue_stored_styles() {
),
);

// Enqueue a block supports (core styles).
// Enqueues a block supports (core styles).
wp_style_engine_get_stylesheet_from_css_rules(
$core_styles_to_enqueue,
array(
Expand Down