Backporting block supports filter callback and registrations and tests #3273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2022
ockham
reviewed
Sep 19, 2022
src/wp-includes/script-loader.php
Outdated
| $style_tag_id = 'core'; | ||
| foreach ( $core_styles_keys as $style_key ) { | ||
| // Adds comment if code is prettified to identify core styles sections in debugging. | ||
| $should_prettify = isset( $options['prettify'] ) ? true === $options['prettify'] : defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG; |
Contributor
There was a problem hiding this comment.
Could consider moving this line before of the loop. (Not a blocker ofc.)
Contributor
There was a problem hiding this comment.
Agreed @ockham. While not a blocker, it's a quick change that could be made in the PR or prior to commit.
ockham
approved these changes
Sep 19, 2022
costdev
approved these changes
Sep 19, 2022
Contributor
costdev
left a comment
costdev
left a comment
There was a problem hiding this comment.
Just one minor thought but other than that, LGTM! 👍
audrasjb
approved these changes
Sep 19, 2022
Contributor
audrasjb
left a comment
audrasjb
left a comment
There was a problem hiding this comment.
LGTM. I committed the two proposed changes.
Contributor
|
Committed in https://core.trac.wordpress.org/changeset/54214 |
This was referenced Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎼 So much, So much clean 🎶
This is combination of of @ockham's changes in #3259, which is a fork of @ramonjd's #3218.
The purpose here is to
SCRIPT_DEBUGin tests. See comment and the Gutenberg PRProps to @gziolo and @ockham
Trac ticket: https://core.trac.wordpress.org/ticket/56467
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.