Performance improvements in site editor dynamic template names #3404
Conversation
| 'taxonomy' => $taxonomy, | ||
| 'hide_empty' => false, | ||
| 'name' => $term_title, | ||
| 'update_post_term_cache' => false, |
There was a problem hiding this comment.
| 'update_post_term_cache' => false, | |
| 'update_term_meta_cache' => false, |
| 'post_type' => $post_type, | ||
| 'posts_per_page' => 1, | ||
| 'update_post_meta_cache' => false, | ||
| 'update_post_term_cache' => false, |
There was a problem hiding this comment.
'ignore_sticky_posts' => true,
'no_found_rows' => true,
Should likely add these as well.
There was a problem hiding this comment.
Does this not need post status?
peterwilsoncc
left a comment
peterwilsoncc
left a comment
There was a problem hiding this comment.
A few notes inline but I am happy to defer to Jonny on this.
| 'hide_empty' => false, | ||
| 'slug' => $slug, | ||
| 'number' => 1, | ||
| 'update_post_term_cache' => false, |
There was a problem hiding this comment.
| 'update_post_term_cache' => false, | |
| 'update_term_meta_cache' => false, |
| 'taxonomy' => $taxonomy, | ||
| 'hide_empty' => false, | ||
| 'name' => $term_title, | ||
| 'update_post_term_cache' => false, |
There was a problem hiding this comment.
Should this have number => 2 as the test is for the existence of duplicates but doesn't indicate how many there are? Is it worth it?
| 'post_type' => $post_type, | ||
| 'post_status' => 'publish', | ||
| 'update_post_meta_cache' => false, | ||
| 'update_post_term_cache' => false, |
There was a problem hiding this comment.
Should this have number => 2 as the test is for the existence of duplicates but doesn't indicate how many there are? Is it worth it?
It could probably do with these too:
'ignore_sticky_posts' => true,
'no_found_rows' => true,
|
Closed in favor of #3424 and merged into core in https://core.trac.wordpress.org/changeset/54445. |
3 participants
Suggestions from @spacedmonkey in WordPress/gutenberg#44645.
Trac ticket: https://core.trac.wordpress.org/ticket/56467