Dynamic templates names WP_Query fixes #3440
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacedmonkey
approved these changes
Oct 11, 2022
ockham
approved these changes
Oct 11, 2022
Contributor
ockham
left a comment
ockham
left a comment
There was a problem hiding this comment.
With this applied, the Post Editor works again 👍
Thank you @dream-encode!
| $terms_with_same_title_query = $term_query->query( $args ); | ||
|
|
||
| if ( count( $terms_with_same_title ) > 1 ) { | ||
| if ( count( $terms_with_same_title_query->terms ) > 1 ) { |
Member
There was a problem hiding this comment.
This should not be needed. query returns the array of terms. But it can't hurt.
Contributor
|
Merged into core by @dream-encode in https://core.trac.wordpress.org/changeset/54494. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/56467
Follow-up to #3424.