Skip to content

Improve performance of WP_Theme_JSON::get_merged_data method #3441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oandregal wants to merge 1 commit into from
Closed

Improve performance of WP_Theme_JSON::get_merged_data method #3441

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
get_merged_data: start from an existing theme.json 
get_merged_data is now a hotpath that is called many times.
By improving small things that are repeated multiple times
we get more performance wins.

Instead of starting with an empty WP_Theme_JSON and call the merge operation
we start by using the existing WP_Theme_JSON from core.

This reduces from 402 to 326 the number of calls of the low-level
WP_Theme_JSON->merge method.
  • Loading branch information
@oandregal
oandregal committed Oct 14, 2022
commit 0c676f363b19fb1d1196c263e363f42193081b86
3 changes: 1 addition & 2 deletions src/wp-includes/class-wp-theme-json-resolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,8 +548,7 @@ public static function get_merged_data( $origin = 'custom' ) {
_deprecated_argument( __FUNCTION__, '5.9.0' );
}

$result = new WP_Theme_JSON();
$result->merge( static::get_core_data() );
$result = static::get_core_data();
$result->merge( static::get_block_data() );
$result->merge( static::get_theme_data() );

Expand Down