-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Editor: Introduce new API method that register block from block.json metadata file
#346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ocean90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DocBlocks needs some minor formatting updates.
Co-authored-by: Dominik Schilling <[email protected]>
|
@ocean90, is it good to go now? Thank you for review, by the way 👍 |
ocean90
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor changes, looks good otherwise.
Co-authored-by: Dominik Schilling <[email protected]>
Trac ticket: https://core.trac.wordpress.org/ticket/50263
This patch includes changes added to Gutenberg in:
register_block_type_from_metadatato handle assets gutenberg#22519This is how the interface looks like:
This function is going to be used to register all blocks on the server when backporting the block editor changes in https://core.trac.wordpress.org/ticket/50420.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.