Fix block registration from metadata #3501
Conversation
aristath
left a comment
aristath
left a comment
There was a problem hiding this comment.
Adding some notes regarding the changes done in this PR
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Left one minor feedback.
aristath
force-pushed
the
fix/block-registration
branch
from
99e2cbe to
d2f4977
Compare
Co-authored-by: Mukesh Panchal <[email protected]>
…ix/block-registration
|
Added PHPUnit tests and fixed issues that surfaced from said tests. |
Co-authored-by: Colin Stewart <[email protected]>
Co-authored-by: Colin Stewart <[email protected]>
Co-authored-by: Colin Stewart <[email protected]>
…ix/block-registration
Co-authored-by: Mukesh Panchal <[email protected]>
spacedmonkey
left a comment
spacedmonkey
left a comment
There was a problem hiding this comment.
Please consider 0bfc842. This change will revert this change.
Can you please elaborate? How does it revert that change? I don't see it 🤔 |
In 0bfc842, I made it so the file_exists is not run on the core blocks. The file exists is pointless as it always exists and ends up I/O. In this PR, you move the file_exists out the if statement, make it run again always, reverting my change. |
|
@aristath Is this good to commit. |
|
Yes, it is. 👍 |
|
Thanks for the PR! Merged in r57026. |
5 participants
Trac ticket: https://core.trac.wordpress.org/ticket/56865
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.