Skip to content

Use low-level cache for get_user_data_from_wp_global_styles(). #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
peterwilsoncc wants to merge 5 commits into from
Closed

Use low-level cache for get_user_data_from_wp_global_styles(). #3517

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fafe0b8
Add message to each assertion.
peterwilsoncc Oct 24, 2022
b75ab81
Use low-level cache for get_user_data_from_wp_global_styles().
peterwilsoncc Oct 24, 2022
a60b5b9
Global styles require an admin account to create taxo.
peterwilsoncc Oct 24, 2022
c1faaa7
Test for cached queries with logged out users.
peterwilsoncc Oct 24, 2022
cc5b0ea
Merge branch 'trunk' into gb44946-use-low-level-cache-for-user-data-g…
peterwilsoncc Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add message to each assertion.
  • Loading branch information
@peterwilsoncc
peterwilsoncc committed Oct 24, 2022
commit fafe0b8c2bc764b9e7277d7b6b66a308b1697d82
6 changes: 3 additions & 3 deletions tests/phpunit/tests/theme/wpThemeJsonResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,16 +632,16 @@ function test_get_user_data_from_wp_global_styles_does_not_use_uncached_queries(
$this->assertSame( 0, $query_count, 'Unexpected SQL queries detected for the wp_global_style post type' );

$user_cpt = WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles( $theme );
$this->assertEmpty( $user_cpt );
$this->assertEmpty( $user_cpt, 'User CPT is expected to be empty.' );

$user_cpt = WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles( $theme, true );
$this->assertNotEmpty( $user_cpt );
$this->assertNotEmpty( $user_cpt, 'User CPT is expected not to be empty.' );

$query_count = count( $this->queries );
for ( $i = 0; $i < 3; $i ++ ) {
$new_user_cpt = WP_Theme_JSON_Resolver::get_user_data_from_wp_global_styles( $theme );
WP_Theme_JSON_Resolver::clean_cached_data();
$this->assertSameSets( $user_cpt, $new_user_cpt );
$this->assertSameSets( $user_cpt, $new_user_cpt, "User CPTs do not match on run {$i}." );
}
$query_count = count( $this->queries ) - $query_count;
$this->assertSame( 0, $query_count, 'Unexpected SQL queries detected for the wp_global_style post type' );
Expand Down