Skip to content

Backport: Gutenberg 43660 - Separator color bugfix #3522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cbravobernal wants to merge 6 commits into from
Closed

Backport: Gutenberg 43660 - Separator color bugfix #3522

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e4bbc98
Add backport for the bugfix
cbravobernal Oct 25, 2022
cb62823
Update version on comment
cbravobernal Nov 3, 2022
620a79a
Update class name without Gutenberg on tests
cbravobernal Nov 4, 2022
11021ea
Try fix blank space
cbravobernal Nov 8, 2022
8a0be43
Tweaks from reviews
dream-encode Nov 10, 2022
b4905cb
WPCS
dream-encode Nov 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
WPCS
  • Loading branch information
@dream-encode
dream-encode committed Nov 10, 2022
commit b4905cbf4c62daa1ccb272e900e78f94f0d5da74
10 changes: 5 additions & 5 deletions tests/phpunit/tests/theme/wpThemeJson.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4035,7 +4035,7 @@ public function test_update_separator_declarations( $separator_block_settings, $
function data_update_separator_declarations() {
return array(
// If only background is defined, test that includes border-color to the style so it is applied on the front end.
'only background' => array(
'only background' => array(
array(
'color' => array(
'background' => 'blue',
Expand All @@ -4044,7 +4044,7 @@ function data_update_separator_declarations() {
'expected_output' => 'body { margin: 0; }.wp-site-blocks > .alignleft { float: left; margin-right: 2em; }.wp-site-blocks > .alignright { float: right; margin-left: 2em; }.wp-site-blocks > .aligncenter { justify-content: center; margin-left: auto; margin-right: auto; }.wp-block-separator{background-color: blue;color: blue;}',
),
// If background and text are defined, do not include border-color, as text color is enough.
'background and text, no border-color' => array(
'background and text, no border-color' => array(
array(
'color' => array(
'background' => 'blue',
Expand All @@ -4054,7 +4054,7 @@ function data_update_separator_declarations() {
'expected_output' => 'body { margin: 0; }.wp-site-blocks > .alignleft { float: left; margin-right: 2em; }.wp-site-blocks > .alignright { float: right; margin-left: 2em; }.wp-site-blocks > .aligncenter { justify-content: center; margin-left: auto; margin-right: auto; }.wp-block-separator{background-color: blue;color: red;}',
),
// If only text is defined, do not include border-color, as by itself is enough.
'only text' => array(
'only text' => array(
array(
'color' => array(
'text' => 'red',
Expand All @@ -4063,7 +4063,7 @@ function data_update_separator_declarations() {
'expected_output' => 'body { margin: 0; }.wp-site-blocks > .alignleft { float: left; margin-right: 2em; }.wp-site-blocks > .alignright { float: right; margin-left: 2em; }.wp-site-blocks > .aligncenter { justify-content: center; margin-left: auto; margin-right: auto; }.wp-block-separator{color: red;}',
),
// If background, text, and border-color are defined, include everything, CSS specifity will decide which to apply.
'background, text, and border-color' => array(
'background, text, and border-color' => array(
array(
'color' => array(
'background' => 'blue',
Expand All @@ -4076,7 +4076,7 @@ function data_update_separator_declarations() {
'expected_output' => 'body { margin: 0; }.wp-site-blocks > .alignleft { float: left; margin-right: 2em; }.wp-site-blocks > .alignright { float: right; margin-left: 2em; }.wp-site-blocks > .aligncenter { justify-content: center; margin-left: auto; margin-right: auto; }.wp-block-separator{background-color: blue;border-color: pink;color: red;}',
),
// If background and border color are defined, include everything, CSS specifity will decide which to apply.
'background, text, and border-color' => array(
'background, text, and border-color' => array(
array(
'color' => array(
'background' => 'blue',
Expand Down