Skip to content

Fix performance issue #3609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spacedmonkey wants to merge 5 commits into from
Closed

Fix performance issue #3609

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8c9ecf3
Fix performance issue
spacedmonkey Nov 11, 2022
25196f9
Merge branch 'trunk' into fix/57077
spacedmonkey Nov 14, 2022
1946f71
Merge branch 'trunk' into fix/57077
spacedmonkey Dec 14, 2022
0e14274
Also change `_add_block_template_part_area_info`.
spacedmonkey Dec 14, 2022
0a10f50
Merge branch 'trunk' into fix/57077
spacedmonkey Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/wp-includes/block-template-utils.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,8 @@ function _add_block_template_info( $template_item ) {
return $template_item;
}

$theme_data = WP_Theme_JSON_Resolver::get_theme_data()->get_custom_templates();
$theme_data = WP_Theme_JSON_Resolver::get_theme_data( array(), array( 'with_supports' => false ) )->get_custom_templates();
Copy link
Member Author

@spacedmonkey spacedmonkey Nov 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixarntz @desrosj @peterwilsoncc This work, because, supports are not needed here. You just need a WP_Theme_Json object. Adding these params, means that it hits a cache that it would not before. This function is called 300+ times a page load, there some serious savings here.


if ( isset( $theme_data[ $template_item['slug'] ] ) ) {
$template_item['title'] = $theme_data[ $template_item['slug'] ]['title'];
$template_item['postTypes'] = $theme_data[ $template_item['slug'] ]['postTypes'];
Expand All @@ -371,7 +372,7 @@ function _add_block_template_info( $template_item ) {
*/
function _add_block_template_part_area_info( $template_info ) {
if ( WP_Theme_JSON_Resolver::theme_has_support() ) {
$theme_data = WP_Theme_JSON_Resolver::get_theme_data()->get_template_parts();
$theme_data = WP_Theme_JSON_Resolver::get_theme_data( array(), array( 'with_supports' => false ) )->get_template_parts();
Copy link
Member Author

@spacedmonkey spacedmonkey Dec 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergeyBiryukov This works well!

}

if ( isset( $theme_data[ $template_info['slug'] ]['area'] ) ) {
Expand Down