Skip to content

wp_get_global_stylesheet: substitute 1-minute transient by non-persistent object cache #3712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oandregal wants to merge 13 commits into from
Closed

wp_get_global_stylesheet: substitute 1-minute transient by non-persistent object cache #3712

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
c23cc4c
wp_get_global_stylesheet: substitute 1-minute transient by object cache
oandregal Dec 1, 2022
f84f94c
Move hook to default-filters.php
oandregal Dec 1, 2022
8707830
Make theme_json as non-persistent at load
oandregal Dec 13, 2022
d39b5e4
Add test_switching_themes_recalculates_stylesheet
oandregal Dec 13, 2022
95fd03a
Add non-persistent group to all places
oandregal Dec 13, 2022
6db5380
Update tests/phpunit/tests/theme/wpGetGlobalStylesheet.php
oandregal Dec 14, 2022
9c82e0b
Update src/wp-includes/global-styles-and-settings.php
oandregal Dec 15, 2022
a0ae741
Switch back to default theme
oandregal Dec 15, 2022
45536da
Switch back before assertions
oandregal Dec 16, 2022
af0cb51
Add comment about use of WP_DEBUG
oandregal Jan 20, 2023
5477120
Updating formatting and inline comments
hellofromtonya Jan 26, 2023
d9c0909
Delete cache in wp_clean_theme_json_cache()
hellofromtonya Jan 26, 2023
8d3fcb4
Merge branch 'trunk' into update/transient-to-object-cache-in-wp-get-…
felixarntz Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update src/wp-includes/global-styles-and-settings.php 
Co-authored-by: Andrew Ozz <[email protected]>
  • Loading branch information
@oandregal @azaozz
oandregal and azaozz committed Jan 20, 2023
commit 9c82e0bed628f91be0463ea46d180d4ffe46e3e8
2 changes: 1 addition & 1 deletion src/wp-includes/global-styles-and-settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ function wp_get_global_styles( $path = array(), $context = array() ) {
function wp_get_global_stylesheet( $types = array() ) {
// Ignore cache when `WP_DEBUG` is enabled, so it doesn't interfere with the theme developers workflow.
$can_use_cached = empty( $types ) && ! WP_DEBUG;
/**
/*
* By using the 'theme_json' group, this data is marked to be non-persistent across requests.
* See `wp_cache_add_non_persistent_groups` in src/wp-includes/load.php and other places.
*
Expand Down