Skip to content

Backport min-height block support feature #3940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrewserong wants to merge 13 commits into from
Closed

Backport min-height block support feature #3940

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a668ff3
Backport min-height block support feature
andrewserong Jan 30, 2023
c2bb6cd
Fix failing tests
andrewserong Jan 30, 2023
c3be880
Fix linting issue
andrewserong Jan 30, 2023
df4d498
Add missing line
andrewserong Jan 30, 2023
e79718f
Add full stop to comment
andrewserong Jan 31, 2023
6b1b594
Simplify tests
andrewserong Jan 31, 2023
19fa05e
Fix linting issue
andrewserong Jan 31, 2023
432be91
Empty commit to rerun tests
andrewserong Jan 31, 2023
69e218f
Update data provider docblock.
andrewserong Feb 1, 2023
adb55ca
Renames test file for coding standard
hellofromtonya Feb 1, 2023
cf79639
Rename test class to coding standards
hellofromtonya Feb 1, 2023
811495e
Minor formatting in tests
hellofromtonya Feb 1, 2023
12cebb4
Capitalize 1st letter of function name
hellofromtonya Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor formatting in tests
  • Loading branch information
@hellofromtonya
hellofromtonya committed Feb 1, 2023
commit 811495eec6d32b0702165642067b2b29b73578ab
5 changes: 2 additions & 3 deletions tests/phpunit/tests/block-supports/wpApplyDimensionsSupport.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
*
* @covers ::wp_apply_dimensions_support
*/

class Tests_Block_Supports_wpApplyDimensionsSupport extends WP_UnitTestCase {
/**
* @var string|null
Expand Down Expand Up @@ -33,8 +32,8 @@ public function tear_down() {
* @dataProvider data_minimum_height_block_support
*
* @param string $block_name The test block name to register.
* @param mixed $dimensions The dimensions block support settings.
* @param mixed $expected An expected return value.
* @param mixed $dimensions The dimensions block support settings.
* @param mixed $expected The expected results.
*/
public function test_minimum_height_block_support( $block_name, $dimensions, $expected ) {
$this->test_block_name = $block_name;
Expand Down