Skip to content

Rest API: add /revisions endpoint for global styles #4606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ramonjd wants to merge 21 commits into from
Closed

Rest API: add /revisions endpoint for global styles #4606

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
e421e6f
Adds an endpoint that returns revisions for the global styles custom …
ramonjd Jun 13, 2023
f24d1a5
Rolled back unnecessary custom post changes
ramonjd Jun 13, 2023
9b44f21
Added rest endpoint to reset schema
ramonjd Jun 13, 2023
5323981
generated fixtures via npm run test:php -- --filter WP_Test_REST_Sche…
ramonjd Jun 13, 2023
f51484e
Adds prepare_date_response to parse and format the date in the respon…
ramonjd Jun 14, 2023
4b1876c
tearing down after tests: deleting users
ramonjd Jun 14, 2023
6a67883
post name should be different to the one created in global styles res…
ramonjd Jun 14, 2023
3a8c04a
Ticket no in tests
ramonjd Jun 16, 2023
8ff9685
Adding feedback:
ramonjd Jun 23, 2023
bed64da
Updated annotations that refer to duplicates
ramonjd Jun 23, 2023
13a7ad1
Returning error if there is one from prepare_item_for_response
ramonjd Jun 23, 2023
05d4247
updated fixtures
ramonjd Jun 23, 2023
a348276
updated fixtures
ramonjd Jun 23, 2023
c5cc8c5
Reinstate suppress filter.
ramonjd Jun 23, 2023
f9bb652
Only run and set styles and/or settings through WP_Theme_JSON if one …
ramonjd Jun 26, 2023
a00dbc5
forgot contect
ramonjd Jun 26, 2023
6c4e410
updated fixtures
ramonjd Jun 27, 2023
c050b15
updated fixtures
ramonjd Jun 27, 2023
a2a26ec
Update class-wp-rest-global-styles-revisions-controller.php
ramonjd Jun 27, 2023
cfd08e8
Update rest-global-styles-revisions-controller.php
ramonjd Jun 27, 2023
5c8052b
linter!
ramonjd Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updated fixtures
  • Loading branch information
@ramonjd
ramonjd committed Jun 27, 2023
commit 6c4e4106760ff4c43aeab8eb550a29860c5f17ca
6 changes: 3 additions & 3 deletions src/wp-includes/rest-api/endpoints/class-wp-rest-global-styles-revisions-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ public function register_routes() {
* @return array Collection parameters.
*/
public function get_collection_params() {
$collection_params = parent::get_collection_params();
$query_params['context']['default'] = 'view';
$collection_params['offset'] = array(
$collection_params = parent::get_collection_params();
$collection_params['context']['default'] = 'view';
$collection_params['offset'] = array(
'description' => __( 'Offset the result set by a specific number of items.' ),
'type' => 'integer',
);
Expand Down
15 changes: 8 additions & 7 deletions tests/qunit/fixtures/wp-api-generated.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,7 @@ mockedApiResponse.Schema = {
"wp-site-health/v1",
"wp-block-editor/v1"
],
"authentication": {
"application-passwords": {
"endpoints": {
"authorization": "http://example.org/wp-admin/authorize-application.php"
}
}
},
"authentication": [],
"routes": {
"/": {
"namespace": "",
Expand Down Expand Up @@ -9635,6 +9629,13 @@ mockedApiResponse.Schema = {
"required": false
},
"context": {
"description": "Scope under which the request is made; determines fields present in response.",
"type": "string",
"enum": [
"view",
"embed",
"edit"
],
"default": "view",
"required": false
},
Expand Down