Skip to content

Backport: Navigation Post Edit Link #4657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
getdave wants to merge 9 commits into from
Closed

Backport: Navigation Post Edit Link #4657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8fecfbf
Use custom edit link definition on Navigation Post type
getdave Jun 21, 2023
15d4837
Amend link template for Navigation post type
getdave Jun 21, 2023
33c2466
Revert unintended reformatting
getdave Jun 21, 2023
a3ba3f6
Remove new line
getdave Jun 21, 2023
a7bd0f1
Inline comment
getdave Jun 21, 2023
c5ac355
Coerce to string
getdave Jun 21, 2023
40db7c1
Move arg to correct place
getdave Jun 26, 2023
58d9bca
Update tests
getdave Jun 26, 2023
8b0c77a
PHPCS
getdave Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/wp-includes/link-template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1474,6 +1474,8 @@ function get_edit_post_link( $post = 0, $context = 'display' ) {
if ( 'wp_template' === $post->post_type || 'wp_template_part' === $post->post_type ) {
$slug = urlencode( get_stylesheet() . '//' . $post->post_name );
$link = admin_url( sprintf( $post_type_object->_edit_link, $post->post_type, $slug ) );
} elseif ( 'wp_navigation' === $post->post_type ) {
Copy link
Member

@ramonjd ramonjd Jun 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could add an annotation in the get_edit_post_link() PHP doc, e.g., something like

* @since 6.3.0 Adds custom link for wp_navigation post types.

$link = admin_url( sprintf( $post_type_object->_edit_link, (string) $post->ID ) );
} elseif ( $post_type_object->_edit_link ) {
$link = admin_url( sprintf( $post_type_object->_edit_link . $action, $post->ID ) );
}
Expand Down
9 changes: 9 additions & 0 deletions src/wp-includes/post.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,6 +490,14 @@ function create_initial_post_types() {
)
);

$navigation_post_edit_link = 'site-editor.php?' . build_query(
array(
'postId' => '%s',
'postType' => 'wp_navigation',
'canvas' => 'edit',
)
);

register_post_type(
'wp_navigation',
array(
Expand All @@ -516,6 +524,7 @@ function create_initial_post_types() {
'description' => __( 'Navigation menus that can be inserted into your site.' ),
'public' => false,
'_builtin' => true, /* internal use only. don't use this when registering your own post type. */
'_edit_link' => $navigation_post_edit_link, /* internal use only. don't use this when registering your own post type. */
'has_archive' => false,
'show_ui' => true,
'show_in_menu' => false,
Expand Down
20 changes: 20 additions & 0 deletions tests/phpunit/tests/link/getEditPostLink.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,4 +131,24 @@ public function test_get_edit_post_link_for_wp_template_part_post_type() {
$this->assertSame( $link_default_context, get_edit_post_link( $template_part_post ), 'Second argument `$context` has a default context of `"display"`.' );
$this->assertSame( $link_custom_context, get_edit_post_link( $template_part_post, 'something-else' ), 'Pass non-default value in second argument.' );
}

public function test_get_edit_post_link_for_wp_navigation_post_type() {
$navigation_post = self::factory()->post->create_and_get(
array(
'post_type' => 'wp_navigation',
'post_name' => 'my_navigation',
'post_title' => 'My Navigation',
'post_content' => '<!-- wp:navigation-link {"label":"WordPress","type":"custom","url":"http://www.wordpress.org/","kind":"custom"} /-->',
'post_excerpt' => 'Description of my Navigation',
)
);

$post_type_object = get_post_type_object( $navigation_post->post_type );

$link_default_context = admin_url( sprintf( $post_type_object->_edit_link, $navigation_post->ID ) );
$link_custom_context = admin_url( sprintf( $post_type_object->_edit_link, $navigation_post->ID ) );

$this->assertSame( $link_default_context, get_edit_post_link( $navigation_post ), 'Second argument `$context` has a default context of `"display"`.' );
$this->assertSame( $link_custom_context, get_edit_post_link( $navigation_post, 'something-else' ), 'Pass non-default value in second argument.' );
}
}