Site editor: Combine id and class into one element #4695
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joedolson
approved these changes
Jun 26, 2023
Contributor
joedolson
left a comment
joedolson
left a comment
There was a problem hiding this comment.
Is this specific to having gutenberg running? I was only testing against core, and didn't see this. Either way, no problem with it.
Member
Author
Thanks @joedolson! We first noticed it on Gutenberg, but then tested on Core without the plugin active. I had to clean my env and recompile everything to replicate it. |
tellthemachines
approved these changes
Jun 26, 2023
Contributor
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
Thanks for fixing this! Testing the site editor with this branch everything works as expected.
Contributor
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in aef1cb9 have broken the site editor in view and editor modes.
It added an additional wrapper for the site-editor div, which breaks flexbox styling.
props @kevin940726 for finding the bug and proposing the fix
Before
After
Trac ticket: https://core.trac.wordpress.org/ticket/56228
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.