Skip to content

Conversation

@tellthemachines
Copy link
Contributor

@tellthemachines tellthemachines commented Jun 26, 2023

Trac ticket: https://core.trac.wordpress.org/ticket/58623

Currently not working: after installing, there's an error while running the build:js task:

Running "jsvalidate:build" (jsvalidate) task
Validating src/wp-includes/js/media-audiovideo.js  
>> Line 1: Unexpected token )
Validating src/wp-includes/js/media-audiovideo.min.js  
>> Line 1: Unexpected token )
Validating src/wp-includes/js/media-grid.js  
>> Line 1: Unexpected token )
Validating src/wp-includes/js/media-grid.min.js  
>> Line 1: Unexpected token )
Validating src/wp-includes/js/media-models.js  
>> Line 1: Unexpected token )
Validating src/wp-includes/js/media-models.min.js  
>> Line 1: Unexpected token )
Validating src/wp-includes/js/media-views.js  
>> Line 1: Unexpected token )
Validating src/wp-includes/js/media-views.min.js  
>> Line 1: Unexpected token )
Encountered 16 errors.
Warning: Task "jsvalidate:build" failed. Use --force to continue.

I'm not sure if anything should be updated in the webpack config, as the files flagged are built with webpack.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@spacedmonkey
Copy link
Member

@tellthemachines This PR will be blocked by #4152. Becasue of upstream changes. Please review this PR, I will commit and we can continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants