Update npm packages for WordPress 6.3 Beta 1

[ockham]

Follow-up to #4699 / r56065.

Includes WordPress/gutenberg#51978, which fixes the following fatal error:

Fatal error: Uncaught Error: Class 'WP_Navigation_Fallback_Gutenberg' not found

Trac ticket: https://core.trac.wordpress.org/ticket/58623

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[joemcgill]

One deprecation notice that can be avoided, but this fixes the PHP fatal introduce in core. Pre-approving

[joemcgill]

This deprecated function is still being used in render_block_core_navigation. Can that be updated as well before this is merged?

[ockham]

Good spot! I'm afraid I'll leave it for Beta 2 since we're already one hour behind schedule for Beta 1, and it doesn't seem like a total blocker 😅

[ockham]

Activating Gutenberg v16.0.0 alongside this PR seems to result in a fatal error:

Fatal error: Cannot declare class WP_REST_Navigation_Fallback_Controller, because the name is already in use in /var/www/src/wp-content/plugins/gutenberg/lib/experimental/class-wp-rest-navigation-fallback-controller.php on line 0

Yay for name collisions. Looks like we'll need another round of npms 😕

[spacedmonkey]

Yay for name collisions. Looks like we'll need another round of npms 😕

CC @getdave

[westonruter]

What about this Gutenberg reference:

wordpress-develop/src/wp-includes/blocks/navigation-submenu.php

Line 204 in 87a0ad4

$colors_supports = gutenberg_apply_colors_support( $block->block_type, $attributes );

I don't see that file updated here.

[ockham]

Activating Gutenberg v16.0.0 alongside this PR seems to result in a fatal error:

Fatal error: Cannot declare class WP_REST_Navigation_Fallback_Controller, because the name is already in use in /var/www/src/wp-content/plugins/gutenberg/lib/experimental/class-wp-rest-navigation-fallback-controller.php on line 0

Yay for name collisions. Looks like we'll need another round of npms 😕

Ah, interesting. Looks like those collisions have been fixed in GB trunk already — they’re just not present in the current stable version (16.0.0). They will be in 16.1.0, which I believe is scheduled for tomorrow 🤔 : (I’ve confirmed that a GB plugin built from current trunk doesn’t fatal upon activation.)

[ockham]

What about this Gutenberg reference:

wordpress-develop/src/wp-includes/blocks/navigation-submenu.php

Line 204 in 87a0ad4

$colors_supports = gutenberg_apply_colors_support( $block->block_type, $attributes );

I don't see that file updated here.

I'll look into this.

Sidenote, I guess we could really use something like this 😅

[ockham]

What about this Gutenberg reference:

wordpress-develop/src/wp-includes/blocks/navigation-submenu.php

Line 204 in 87a0ad4

$colors_supports = gutenberg_apply_colors_support( $block->block_type, $attributes );

I don't see that file updated here.

I'll look into this.

PR: WordPress/gutenberg#51989

[ockham]

Thank you for reviewing/approving, folks!

As stated in Slack:

Since the tests on this PR are failing (probably because Core trunk is currently in a broken state), I’m considering only landing [this PR right here] for now (which should unbreak Core) and leave the rest for Beta 2. How does that sound? (It should shave off at least another hour of work for now; whereas landing [this PR] should be a matter of a few minutes only.)

[ockham]

Committed to Core in https://core.trac.wordpress.org/changeset/56076/.

[ramonjd]

Sidenote, I guess we could really use something like this 😅

I'll add it to a list that I might never return to. I agree though. I'm sure this has been a problem before

thanks @ockham