Skip to content

Conversation

@ramonjd
Copy link
Member

@ramonjd ramonjd commented Jun 29, 2023

Some missed formatting and also implementing feedback from #4606 (review) (adding missing @covers to tests and swapping order of @ticket and @covers order)

Trac ticket: https://core.trac.wordpress.org/ticket/58524


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Formatting and test annotations to include @Covers
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ramonjd, for the PR. It looks good to me and seems quite simple to merge.

Copy link
Contributor

@tellthemachines tellthemachines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tellthemachines
Copy link
Contributor

committed in r56105 / 41277f1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants