Skip to content

Backport: opt out for Navigation fallback creation #4813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
getdave wants to merge 6 commits into from
Closed

Backport: opt out for Navigation fallback creation #4813

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1f21df9
Add code and update test coverage
getdave Jul 7, 2023
376c91c
Apply suggestions from code review
getdave Jul 7, 2023
3e5ef24
Remove correct filter
getdave Jul 7, 2023
2e7c282
Update to WP prefix
getdave Jul 7, 2023
d83b125
Fix ticket annotation
getdave Jul 10, 2023
c0cc6ae
Improve doc block
getdave Jul 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review
  • Loading branch information
@getdave
getdave authored Jul 7, 2023
commit 376c91cdfc7718c78fd50937d02d730ed3cf4c0f
4 changes: 2 additions & 2 deletions tests/phpunit/tests/editor/navigation-fallback.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,12 @@ public function test_should_return_a_default_fallback_navigation_menu_in_absence
}

/**
* @ticket 58557
* @ticket 58750
* @covers WP_REST_Navigation_Fallback_Controller::get_fallback
*/
public function test_should_not_automatically_create_fallback_if_filter_is_falsey() {

add_filter( 'gutenberg_navigation_should_create_fallback', '__return_false' );
add_filter( 'wp_navigation_should_create_fallback', '__return_false' );

$data = Gutenberg_Navigation_Fallback::get_fallback();

Expand Down