-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add revisioning of post meta, including ‘footnotes’ by default #4859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
117 commits
Select commit
Hold shift + click to select a range
b8bf5ef
Add revisioning of post meta, including ‘footnotes’ by default
adamsilverstein 6667610
correct typo in `src/wp-includes/default-filters.php`
adamsilverstein 15e9e4e
add tests for meta revisioning
adamsilverstein b892323
Try: revisioning in the rest endpoint directly, after meta is saved
adamsilverstein 6235af5
Add _wp_save_post_revision_meta helper that copies revisioned meta to…
adamsilverstein 3a87749
remove direct REST API integration, move save to wp_after_insert_post
adamsilverstein 05d0f86
Clean up revisions save
adamsilverstein 19e1f8a
phpcbf
adamsilverstein 0b86da9
Ensure `$revisions[0]->post_id ` is set before using
adamsilverstein 52dd943
Test work
adamsilverstein ef14c11
Expected revision count is 6
adamsilverstein 31a6d61
Merge branch 'trunk' into ticket/20564
adamsilverstein da8abe6
Add REST API tests for revisioning of post meta.
adamsilverstein d2f0db1
Merge branch 'trunk' into ticket/20564
adamsilverstein 6c9bece
Remove footnote specific revisioning of meta
adamsilverstein 2e74964
phpcbf
adamsilverstein 268385f
Fix test setup
adamsilverstein 4fd4302
Save revisioned meta in `_wp_put_post_revision`
adamsilverstein 3722d1e
Enable setting revisioning in register_meta
adamsilverstein b26a695
phpcs
adamsilverstein 5d6e5b9
remove unused $revisioned_keys
adamsilverstein b4fa33f
Add testing for enabling revisions in `register_meta`
adamsilverstein 1603c55
phpcbf
adamsilverstein d244a39
Use a separate global for revisioned keys `$wp_revisioned_meta_keys`
adamsilverstein d86ec77
Merge branch 'trunk' into ticket/20564
adamsilverstein a80620a
Meta test cleanup to match new defaults
adamsilverstein 885640d
Adjust expected for `test_should_register_persisted_preferences_meta`
adamsilverstein ea4f181
Refine REST tests for meta revisioning
adamsilverstein e63334b
Avoid duplicate keys in `wp_revisioned_meta_keys`
adamsilverstein f4234f8
remove unused `original_post_id`
adamsilverstein 1f1e5a0
REST posts endpoint: update revision meta when saving meta
adamsilverstein 6c5061b
test work
adamsilverstein 5bd7e7b
Hook `wp_save_revisioned_meta_fields` on `_wp_put_post_revision` so i…
adamsilverstein 65bfe81
Test cleanup
adamsilverstein 7254e3a
Improve footnote display, show number and content
adamsilverstein 8c3fba2
Save the revisioned meta directly in the REST endpoint
adamsilverstein 26a9d0b
spacing
adamsilverstein 210573b
Merge branch 'trunk' into ticket/20564
adamsilverstein 485f20b
add meta to revisions endpoint
adamsilverstein 167261e
test revisions endpoint returns meta
adamsilverstein 5b5dc0d
new revision meta fields class
adamsilverstein f8d0d30
INCLUDE class-wp-rest-revision-meta-fields
adamsilverstein ea9b8ce
Revision existing meta even when update/insert lacks meta
adamsilverstein 15e8bbd
Test that the revisions endpoint includes meta
adamsilverstein 1e54aa3
Merge branch 'trunk' into ticket/20564
adamsilverstein a3fa561
phpcbf
adamsilverstein 877420e
Merge branch 'trunk' into ticket/20564
adamsilverstein f57b79b
Update REST tests to reflect changed schema
adamsilverstein cad9272
phpcbf
adamsilverstein 57c872a
Improve tests
adamsilverstein ca01058
Finetune tests based on git action failures
adamsilverstein 92590aa
test
adamsilverstein 6fd9a9e
restore footnotes.php from trunk
adamsilverstein f83d353
Merge branch 'trunk' into ticket/20564
adamsilverstein 7f70990
Update wp-api-generated fixtures
adamsilverstein 432a810
fix generated
adamsilverstein d80b7b4
Try: move hooking of revisions
adamsilverstein 7160abb
fire after hooks in revisions controller test
adamsilverstein 96301da
Try only adding revision on update.
TimothyBJacobs e2d0cc7
Use actions properly
TimothyBJacobs 5f07145
Revert "Try only adding revision on update."
TimothyBJacobs afc1109
Don't rewrite everything
TimothyBJacobs ac279e3
Correct logic
TimothyBJacobs 4205d65
Check if the legacy hook is being used
TimothyBJacobs e7b4495
Separate single and multi meta tests. Use native meta fields handler.
TimothyBJacobs 68f6410
Regenerate fixtures
TimothyBJacobs ee35085
Use post meta fields directly
TimothyBJacobs 61bfafc
Respect the object subtype.
TimothyBJacobs c27258a
Always pass a post array
TimothyBJacobs 20874e3
Remove manually revisioning meta. This happens automatically now.
TimothyBJacobs 68a419b
Correct has meta key assertion
TimothyBJacobs 3ee633f
Add clarifying comment and some more fail safes
TimothyBJacobs 1e17f5b
Merge branch 'trunk' into ticket/20564
adamsilverstein 982c553
Merge branch 'trunk' into ticket/20564
adamsilverstein d04574a
Test cleanup, add page and cpt tests
adamsilverstein 3a8f6fc
omyac
adamsilverstein 192e7c0
Merge branch 'trunk' into ticket/20564
adamsilverstein 225a91b
Clean up default filters after trunk merge
adamsilverstein c2482fd
Avoid duplicate revisions since hook change
adamsilverstein 2331d36
Merge branch 'trunk' into ticket/20564
adamsilverstein 5c48c7a
Restore hooks on wp_insert_post for revision - issue was plugin related
adamsilverstein e211ca1
Ensure meta data is revisioned with autosaves
adamsilverstein 7247e93
Cleanup, only check meta when passed
adamsilverstein 891a0e4
Merge branch 'trunk' into ticket/20564
adamsilverstein c35cc5f
Merge branch 'trunk' into ticket/20564
adamsilverstein 826bebb
Merge branch 'trunk' into ticket/20564
adamsilverstein 750dcdc
Hook wp_autosave_post_revisioned_meta_fields on wp_creating_autosave
adamsilverstein 0b88e50
Improve error checking
adamsilverstein 2c02dbc
Update src/wp-includes/rest-api/endpoints/class-wp-rest-revisions-con…
adamsilverstein b5ba2d3
Update src/wp-includes/revision.php
adamsilverstein 95508d9
Hook revision restore on action
adamsilverstein b0b880b
Test revisioning of meta with a default value
adamsilverstein f04a319
phpcs
adamsilverstein e231886
phpcbf
adamsilverstein e1950b0
Autosaves controller - get_metadata_raw is used to avoid retrieving t…
adamsilverstein 6f6e3ce
Update src/wp-includes/revision.php
adamsilverstein b77bf22
Check post_type available in wp_save_revisioned_meta_fields
adamsilverstein b6e221a
Ensure post_type available in wp_restore_post_revision_meta
adamsilverstein 40febf2
typo - missing closing parenthesis
adamsilverstein 69c6107
phpcbf
adamsilverstein f9b760b
If the object_type is set, require a type that supports revisions wh…
adamsilverstein 8360faa
Test enabling revisions for meta when object type doesn’t support rev…
adamsilverstein a1971f7
phpcbf
adamsilverstein 99b2aa8
Update src/wp-includes/rest-api/endpoints/class-wp-rest-autosaves-con…
adamsilverstein b94e1a6
Update src/wp-includes/rest-api/endpoints/class-wp-rest-autosaves-con…
adamsilverstein e09f011
Update src/wp-admin/includes/post.php
adamsilverstein 01a4788
Update src/wp-admin/includes/post.php
adamsilverstein 8e7b72a
spacing
adamsilverstein d6c6ca2
Guard against _wp_put_post_revision returning 0
adamsilverstein 73f6a23
Update src/wp-includes/meta.php
adamsilverstein 3db644c
tabs vs spaces
adamsilverstein 95c9e9d
Update src/wp-includes/rest-api/endpoints/class-wp-rest-autosaves-con…
adamsilverstein 9bab9a9
Improve error message
adamsilverstein dc0b907
Merge branch 'trunk' into ticket/20564
adamsilverstein ab2d500
Merge branch 'trunk' into ticket/20564
adamsilverstein 8bf1727
phpcbf
adamsilverstein c7904ce
phpcbf pt 2
adamsilverstein File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Merge branch 'trunk' into ticket/20564
# Conflicts: # src/wp-includes/blocks/footnotes.php
- Loading branch information
commit 1e54aa33376e308b3b64b7d8cf4d98e89a7ce1d7
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You are viewing a condensed version of this merge commit. You can view the full changes here.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.