Skip to content

Template Editing Mode: Fix checks in 'site-editor.php' #4893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Mamaduka wants to merge 2 commits into from
Closed

Template Editing Mode: Fix checks in 'site-editor.php' #4893

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af57e9c
Template Editing Mode: Fix checks in 'site-editor.php'
Mamaduka Jul 24, 2023
af5a728
Update menu link
Mamaduka Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Template Editing Mode: Fix checks in 'site-editor.php'
  • Loading branch information
@Mamaduka
Mamaduka committed Jul 24, 2023
commit af57e9cf20ed76008d7f63fd4a36e79497d59199
5 changes: 4 additions & 1 deletion src/wp-admin/site-editor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,10 @@
wp_die( __( 'The theme you are currently using is not compatible with the Site Editor.' ) );
}

$is_template_part_editor = isset( $_GET['postType'] ) && 'wp_template_part' === sanitize_key( $_GET['postType'] );
$is_template_part = isset( $_GET['postType'] ) && 'wp_template_part' === sanitize_key( $_GET['postType'] );
$is_template_part_path = isset( $_GET['path'] ) && 'wp_template_partall' === sanitize_key( $_GET['path'] );
$is_template_part_editor = $is_template_part || $is_template_part_path;
Comment on lines +26 to +28
Copy link
Member Author

@Mamaduka Mamaduka Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both checks are needed now. When editing a template part query will contain wp_template_part, and when viewing the list page, it will be /wp_template_part/all.

The slashes are removed by sanitize_key.


if ( ! wp_is_block_theme() && ! $is_template_part_editor ) {
wp_die( __( 'The theme you are currently using is not compatible with the Site Editor.' ) );
}
Expand Down