-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Store merged data in memory #5024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
joemcgill
wants to merge
8
commits into
WordPress:trunk
from
joemcgill:update/57789-store-merged-theme-json
Closed
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8f3fbcd
Store merged data in memory
joemcgill b9cd9c8
Allow cached merged data to be cleaned
joemcgill d1319a1
Validate block registration for merged data
joemcgill f985db4
Merge branch 'trunk' into update/57789-store-merged-theme-json
joemcgill 6811e6d
Cache theme supports data for use when caching merged data
joemcgill b477c3d
Remove unused global var
joemcgill a5922fe
Don't return early in get_theme_data
joemcgill 3727709
Apply PR feedback
joemcgill File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Cache theme supports data for use when caching merged data
- Loading branch information
commit 6811e6d1c22ade5dcb9be77f83c130674a7cf9ed
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Theme support data only matters for the
themeandcustomorigins, so I think we should only apply this check if the given origin is one of those, to keep caches warm for the other two origins.