AJAX request returns critical error in class-wp-date-query.php #5108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| if ( is_array( $date_query['year'] ) ) { | ||
| $_year = reset( $date_query['year'] ); | ||
| $_year = intval(reset( $date_query['year'] )); |
There was a problem hiding this comment.
Suggested change
| $_year = intval(reset( $date_query['year'] )); | |
| $_year = intval( reset( $date_query['year'] ) ); |
| */ | ||
| if ( is_array( $date_query['year'] ) ) { | ||
| $_year = reset( $date_query['year'] ); | ||
| $_year = intval( reset( $date_query['year'] )) ; |
Member
There was a problem hiding this comment.
Suggested change
| $_year = intval( reset( $date_query['year'] )) ; | |
| $_year = intval( reset( $date_query['year'] ) ); |
| $_year = intval( reset( $date_query['year'] )) ; | ||
| } else { | ||
| $_year = $date_query['year']; | ||
| $_year = intval( $date_query['year']); |
Member
There was a problem hiding this comment.
Suggested change
| $_year = intval( $date_query['year']); | |
| $_year = intval( $date_query['year'] ); |
jrfnl
requested changes
Aug 29, 2023
| */ | ||
| if ( is_array( $date_query['year'] ) ) { | ||
| $_year = reset( $date_query['year'] ); | ||
| $_year = intval( reset( $date_query['year'] )) ; |
Member
There was a problem hiding this comment.
reset() can return false. I think the condition wrapping this should probably be adjusted to also check for a non-empty array to avoid this.
Also, please do not use intval() except as a callback. A simple (int) cast is better.
| $_year = intval( reset( $date_query['year'] )) ; | ||
| } else { | ||
| $_year = $date_query['year']; | ||
| $_year = intval( $date_query['year']); |
Member
There was a problem hiding this comment.
Same thing: please use (int) instead of intval().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this error: PHP Fatal error: Uncaught TypeError: mktime(): Argument #6 ($year) must be of type ?int, string given in /wp-includes/class-wp-date-query.php:320
Trac ticket: https://core.trac.wordpress.org/ticket/59235