Skip to content

Blocks: Refactor the check against self for block hooks #5218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gziolo wants to merge 4 commits into from
Closed

Blocks: Refactor the check against self for block hooks #5218

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cbcaf33
Blocks: Refactor the check against self for block hooks
gziolo Sep 14, 2023
967798d
Ensure that only an array gets validated for block hooks
gziolo Sep 14, 2023
d70619c
Fix the spacing issue
gziolo Sep 14, 2023
2089f54
Refactor code based on the review feedback
gziolo Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix the spacing issue
  • Loading branch information
@gziolo
gziolo committed Sep 18, 2023
commit d70619cb08eb8e9dff5c4a61512afa07fa0368f2
2 changes: 1 addition & 1 deletion tests/phpunit/tests/blocks/register.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1097,6 +1097,6 @@ public function test_register_block_hooks_targeting_itself() {
$this->assertSameSets(
array( 'tests/other-block' => 'last' ),
$block_type->block_hooks
);
);
}
}