Skip to content

Fix post editor layout when content block has no attributes. #5221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tellthemachines wants to merge 10 commits into from
Closed

Fix post editor layout when content block has no attributes. #5221

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cd973da
Fix post editor layout when content block has no attributes.
tellthemachines Sep 15, 2023
bb0636e
Add new theme to list
tellthemachines Sep 15, 2023
b4e9242
Return null by default.
tellthemachines Sep 18, 2023
cb423e8
Update tests/phpunit/tests/blocks/editor.php
tellthemachines Sep 18, 2023
2f8c135
Update function logic and test.
tellthemachines Sep 18, 2023
3425504
Update tests/phpunit/tests/blocks/editor.php
tellthemachines Sep 18, 2023
b55f10e
Update tests/phpunit/tests/blocks/editor.php
tellthemachines Sep 18, 2023
9feab8e
Improve comment
tellthemachines Sep 18, 2023
c1c2f36
Update src/wp-includes/block-editor.php
tellthemachines Sep 19, 2023
0e75e53
Check post content attributes are not output with classic themes
tellthemachines Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Return null by default.
  • Loading branch information
@tellthemachines
tellthemachines committed Sep 18, 2023
commit b4e92428c3407a1b2daeeddadf3692f59bb63ea2
3 changes: 2 additions & 1 deletion src/wp-includes/block-editor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,7 @@ function wp_get_first_block( $blocks, $block_name ) {
* Retrieves Post Content block attributes from the current post template.
*
* @since 6.3.0
* @since 6.4.0 return null by default and return empty array when Post Content block exists. but has no attributes.
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 Sep 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @since 6.4.0 return null by default and return empty array when Post Content block exists. but has no attributes.
* @since 6.4.0 return null by default or an empty array when the Post Content block exists. but has no attributes.

* @access private
*
* @global int $post_ID
Expand Down Expand Up @@ -462,7 +463,7 @@ function wp_get_post_content_block_attributes() {
}
}

return array();
return null;
}

/**
Expand Down