Font Library #5285
Removing 'gutenberg' translation domain
- Loading branch information
commit 534264e4182246cb2054f292200ed228bc8e1900
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -143,13 +143,13 @@ private function get_validation_errors( $font_families, $files ) { | |||||
| $error_messages = array(); | ||||||
|
|
||||||
| if ( ! is_array( $font_families ) ) { | ||||||
| $error_messages[] = __( 'fontFamilies should be an array of font families.' ); | ||||||
| return $error_messages; | ||||||
| } | ||||||
|
|
||||||
| // Checks if there is at least one font family. | ||||||
| if ( count( $font_families ) < 1 ) { | ||||||
| $error_messages[] = __( 'fontFamilies should have at least one font family definition.' ); | ||||||
| return $error_messages; | ||||||
| } | ||||||
|
|
||||||
|
|
@@ -163,7 +163,7 @@ private function get_validation_errors( $font_families, $files ) { | |||||
| ) { | ||||||
| $error_messages[] = sprintf( | ||||||
| // translators: 1: font family index. | ||||||
|
||||||
| // translators: 1: font family index. | |
| /* translators: %s: font family index. */ |
Translator comments are in the form of:
/* translators: <token || number>: Description<comma || period> */🔢 Applies elsewhere in the PR.
See the information for Plugins, the best reference I could find 😅. This is the same practice used in WordPress Core.
Outdated
Member
There was a problem hiding this comment.
- This should use sprintf with placeholders for things like
fontFamily - Why square brackets instead of parentheses? That's not common AFAIK
Member
There was a problem hiding this comment.
The same goes for all the other error messages, really.
There was a problem hiding this comment.
Why square brackets instead of parentheses? That's not common AFAIK
One place I do see brackets used is when validating an object in the request from the endpoint schema (see
wordpress-develop/src/wp-includes/rest-api.php
Line 2344 in 2ae28c5
The error messages use a string like object_name[property_name] to refer to the property being validated. We're using this format specifically for custom validation error messages in the new controller implementation, to match the error format from the default schema validation (now with appropriate sprintf usage, see WordPress/gutenberg#58675).
Outdated
Member
There was a problem hiding this comment.
As noted elsewhere, params should use snack case.
Member
There was a problem hiding this comment.
Other schema are cached for performance reasons. Why was this avoided here.
Outdated
Member
There was a problem hiding this comment.
This should return an array of remove fonts and boolean.
Author
There was a problem hiding this comment.
Updated with the changes of this PR WordPress/gutenberg#54829. The output of the install and uninstall endpoints are now standardized for success and errors.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should use sprintf and use a placeholder for
fontFamilies. And of course proper translator comments.