Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
70 commits
Select commit Hold shift + click to select a range
69ed6a2
WIP Playwright migration
swissspidy Sep 27, 2023
d76a2c3
Convert visual regression tests
swissspidy Sep 27, 2023
f1f7ce1
Fix mask config
swissspidy Sep 27, 2023
792c758
Initial conversion of edit posts tests
swissspidy Sep 27, 2023
8fb0560
Fix file ext
swissspidy Sep 27, 2023
c7b7ce6
Convert dashboard test
swissspidy Sep 27, 2023
a88e396
Convert another test
swissspidy Sep 27, 2023
c91d0ca
Improve test
swissspidy Sep 27, 2023
0778ffe
Remove types package again
swissspidy Sep 28, 2023
cb04187
Merge branch 'trunk' into add/pw-performance-tests
swissspidy Sep 28, 2023
e691f09
Remove debug cruft
swissspidy Sep 28, 2023
ca36ecb
Install browsers separately
swissspidy Sep 28, 2023
b044cff
Fix webServer command
swissspidy Sep 28, 2023
2e17562
Merge branch 'trunk' into add/pw-performance-tests
swissspidy Sep 28, 2023
85021bb
Some more bug fixes
swissspidy Sep 28, 2023
f6fd1ca
Update dashboard tests
Mamaduka Sep 28, 2023
fda76fc
Update edit post tests
Mamaduka Sep 28, 2023
5afa823
Use keyPress util
Mamaduka Sep 28, 2023
9ae926f
Update empty and restore trash tests
Mamaduka Sep 28, 2023
21e9f12
Try using same PW version as Gutenberg and wp-scripts
Mamaduka Sep 28, 2023
5ffb5d7
Install deps again after git checkout
swissspidy Sep 28, 2023
5ca807c
Remove commented out config
swissspidy Sep 28, 2023
1cd3f2f
Fix test title
swissspidy Sep 28, 2023
fb49007
Use env var for prefix instead of argument
swissspidy Sep 28, 2023
6f3a89f
Fix app passwords tests
swissspidy Sep 28, 2023
53691a1
Debug: use different reporter on CI
swissspidy Sep 28, 2023
f488294
Update app password tests
Mamaduka Sep 28, 2023
d401663
Remove leftovers
swissspidy Sep 28, 2023
2109765
Move order
swissspidy Sep 28, 2023
c346d2b
Make Gutenberg test more robust
swissspidy Sep 28, 2023
1079d5c
Make comparison script more robust
swissspidy Sep 28, 2023
14d7496
Further improve comparison script
swissspidy Sep 28, 2023
cb8e4d6
Undo reporter change
swissspidy Sep 28, 2023
af97340
Merge branch 'trunk' into add/pw-performance-tests
swissspidy Sep 29, 2023
356d967
Merge branch 'trunk' into add/pw-performance-tests
swissspidy Oct 2, 2023
a3048ac
Remove `PUPPETEER_SKIP_DOWNLOAD`
swissspidy Oct 2, 2023
4141e47
Update readmes
swissspidy Oct 2, 2023
737b58c
Make Gutenberg plugin tests more resilient
Mamaduka Oct 2, 2023
8f8a971
Merge branch 'trunk' into add/pw-performance-tests
swissspidy Oct 2, 2023
0e8bd0c
Merge branch 'trunk' into add/pw-performance-tests
swissspidy Oct 5, 2023
dd3000a
Merge branch 'trunk' into add/pw-performance-tests
swissspidy Oct 10, 2023
fb78280
Extend base PW config from wp-scripts
swissspidy Oct 10, 2023
bc35c5e
Fix config
swissspidy Oct 10, 2023
8d64ece
Merge branch 'trunk' into add/pw-performance-tests
swissspidy Oct 10, 2023
827d43d
Fix indentation
swissspidy Oct 10, 2023
9f07be2
use `require.resolve`
swissspidy Oct 10, 2023
53b5166
Fix double comment
swissspidy Oct 12, 2023
a027cae
Options, Meta APIs: Check setting group exists before search in unreg…
hellofromtonya Oct 10, 2023
593894a
Patterns: Inject `theme` attribute into Template Part blocks.
ockham Oct 10, 2023
050997c
REST API: Fix issue with Template and Template Part Revision/Autosave…
spacedmonkey Oct 10, 2023
fc0e71a
Update/Install: Deactivate Gutenberg plugin version older than 16.5.
hellofromtonya Oct 10, 2023
6e632c1
WordPress 6.4 Beta 3.
karmatosed Oct 10, 2023
8e3ae9a
Post WordPress 6.4 Beta 3 version bump.
karmatosed Oct 10, 2023
8544fe3
Build/Test Tools: Correct variable typo.
desrosj Oct 10, 2023
03bdce8
Plugins: Fix broken `sprintf()` call in plugins list table.
costdev Oct 11, 2023
f2d285e
Docs: Use US spelling and correct a typing mistake.
costdev Oct 11, 2023
994d2ab
Help/About: Ensure that focus outline on the Credits screen is not cu…
SergeyBiryukov Oct 11, 2023
889f1a7
Build/Test Tools: Don’t send Slack notification for workflow retries.
desrosj Oct 11, 2023
c2313f9
Editor: Add further test coverage for `wp_render_elements_support()`.
felixarntz Oct 11, 2023
207cdb9
Build/Test Tools: Increase the number of retries when restarting a wo…
desrosj Oct 11, 2023
46d4273
Build/Test Tools: Increase the timeout for the failed workflow.
desrosj Oct 11, 2023
27be854
Build/Test Tools: Remove hardcoded PHPUnit config files.
desrosj Oct 11, 2023
4172c12
Twenty Nineteen: Add margins to editor iframe content.
SergeyBiryukov Oct 12, 2023
15049d6
Mention UI mode in readme
swissspidy Oct 12, 2023
96f591d
Merge branch 'trunk' into add/pw-performance-tests
swissspidy Oct 12, 2023
eba1afa
Revert r56198
swissspidy Oct 12, 2023
aa9fb1c
Apply r56660
swissspidy Oct 12, 2023
ba8db30
Fix env vars
swissspidy Oct 12, 2023
e3da622
Merge branch 'trunk' into add/pw-performance-tests
swissspidy Oct 12, 2023
f837898
Merge branch 'WordPress:trunk' into add/pw-performance-tests
swissspidy Oct 12, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/coding-standards.yml
Original file line number Diff line number Diff line change
Expand Up @@ -142,8 +142,6 @@ jobs:
contents: read
timeout-minutes: 20
if: ${{ github.repository == 'WordPress/wordpress-develop' || github.event_name == 'pull_request' }}
env:
PUPPETEER_SKIP_DOWNLOAD: ${{ true }}

steps:
- name: Checkout repository
Expand Down
27 changes: 26 additions & 1 deletion .github/workflows/end-to-end-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,13 @@ jobs:
# - Sets up Node.js.
# - Logs debug information about the GitHub Action runner.
# - Installs npm dependencies.
# - Install Playwright browsers.
# - Builds WordPress to run from the `build` directory.
# - Starts the WordPress Docker container.
# - Logs the running Docker containers.
# - Logs Docker debug information (about both the Docker installation within the runner and the WordPress container).
# - Install WordPress within the Docker container.
# - Install Gutenberg.
# - Run the E2E tests.
# - Ensures version-controlled files are not modified or deleted.
e2e-tests:
Expand Down Expand Up @@ -90,6 +92,9 @@ jobs:
- name: Install npm Dependencies
run: npm ci

- name: Install Playwright browsers
run: npx playwright install --with-deps

- name: Build WordPress
run: npm run build

Expand All @@ -115,6 +120,9 @@ jobs:
LOCAL_SCRIPT_DEBUG: ${{ matrix.LOCAL_SCRIPT_DEBUG }}
run: npm run env:install

- name: Install Gutenberg
run: npm run env:cli -- plugin install gutenberg --path=/var/www/${{ env.LOCAL_DIR }}

- name: Run E2E tests
run: npm run test:e2e

Expand All @@ -129,6 +137,22 @@ jobs:
- name: Ensure version-controlled files are not modified or deleted
run: git diff --exit-code

slack-notifications:
name: Slack Notifications
uses: WordPress/wordpress-develop/.github/workflows/slack-notifications.yml@trunk
permissions:
actions: read
contents: read
needs: [ e2e-tests ]
if: ${{ github.repository == 'WordPress/wordpress-develop' && github.event_name != 'pull_request' && always() }}
with:
calling_status: ${{ contains( needs.*.result, 'cancelled' ) && 'cancelled' || contains( needs.*.result, 'failure' ) && 'failure' || 'success' }}
secrets:
SLACK_GHA_SUCCESS_WEBHOOK: ${{ secrets.SLACK_GHA_SUCCESS_WEBHOOK }}
SLACK_GHA_CANCELLED_WEBHOOK: ${{ secrets.SLACK_GHA_CANCELLED_WEBHOOK }}
SLACK_GHA_FIXED_WEBHOOK: ${{ secrets.SLACK_GHA_FIXED_WEBHOOK }}
SLACK_GHA_FAILURE_WEBHOOK: ${{ secrets.SLACK_GHA_FAILURE_WEBHOOK }}

failed-workflow:
name: Failed workflow tasks
runs-on: ubuntu-latest
Expand All @@ -141,7 +165,8 @@ jobs:
github.event_name != 'pull_request' &&
github.run_attempt < 2 &&
(
needs.e2e-tests.result == 'cancelled' || needs.e2e-tests.result == 'failure'
contains( needs.*.result, 'cancelled' ) ||
contains( needs.*.result, 'failure' )
)
steps:
- name: Dispatch workflow run
Expand Down
32 changes: 24 additions & 8 deletions .github/workflows/performance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,10 +31,10 @@ permissions: {}

env:
# Performance testing should be performed in an environment reflecting a standard production environment.
WP_DEBUG: false
SCRIPT_DEBUG: false
SAVEQUERIES : false
WP_DEVELOPMENT_MODE: ''
LOCAL_WP_DEBUG: false
LOCAL_SCRIPT_DEBUG: false
LOCAL_SAVEQUERIES: false
LOCAL_WP_DEVELOPMENT_MODE: "''"

# This workflow takes two sets of measurements — one for the current commit,
# and another against a consistent version that is used as a baseline measurement.
Expand All @@ -56,6 +56,7 @@ jobs:
# - Set up Node.js.
# - Log debug information.
# - Install npm dependencies.
# - Install Playwright browsers.
# - Build WordPress.
# - Start Docker environment.
# - Log running Docker containers.
Expand All @@ -73,6 +74,7 @@ jobs:
# - Run performance tests (previous/target commit).
# - Print target performance tests results.
# - Reset to original commit.
# - Install npm dependencies.
# - Set the environment to the baseline version.
# - Run baseline performance tests.
# - Print baseline performance tests results.
Expand Down Expand Up @@ -119,6 +121,9 @@ jobs:
- name: Install npm dependencies
run: npm ci

- name: Install Playwright browsers
run: npx playwright install --with-deps

- name: Build WordPress
run: npm run build

Expand Down Expand Up @@ -182,24 +187,35 @@ jobs:
run: npm run build

- name: Run target performance tests (base/previous commit)
run: npm run test:performance -- --prefix=before
env:
TEST_RESULTS_PREFIX: before
run: npm run test:performance

- name: Print target performance tests results
run: node ./tests/performance/results.js --prefix=before
env:
TEST_RESULTS_PREFIX: before
run: node ./tests/performance/results.js

- name: Reset to original commit
run: git reset --hard $GITHUB_SHA

- name: Install npm dependencies
run: npm ci

- name: Set the environment to the baseline version
run: |
npm run env:cli -- core update --version=${{ env.BASE_TAG }} --force --path=/var/www/${{ env.LOCAL_DIR }}
npm run env:cli -- core version --path=/var/www/${{ env.LOCAL_DIR }}

- name: Run baseline performance tests
run: npm run test:performance -- --prefix=base
env:
TEST_RESULTS_PREFIX: base
run: npm run test:performance

- name: Print baseline performance tests results
run: node ./tests/performance/results.js --prefix=base
env:
TEST_RESULTS_PREFIX: base
run: node ./tests/performance/results.js

- name: Compare results with base
run: node ./tests/performance/compare-results.js ${{ runner.temp }}/summary.md
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/phpunit-tests-run.yml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ env:
LOCAL_DB_VERSION: ${{ inputs.db-version }}
LOCAL_PHP_MEMCACHED: ${{ inputs.memcached }}
PHPUNIT_CONFIG: ${{ inputs.phpunit-config }}
PUPPETEER_SKIP_DOWNLOAD: ${{ true }}

jobs:
# Runs the PHPUnit tests for WordPress.
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/test-coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ on:
permissions: {}

env:
PUPPETEER_SKIP_DOWNLOAD: ${{ true }}
LOCAL_PHP: '7.4-fpm'
LOCAL_PHP_XDEBUG: true
LOCAL_PHP_XDEBUG_MODE: 'coverage'
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/test-npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,6 @@ concurrency:
# Any needed permissions should be configured at the job level.
permissions: {}

env:
PUPPETEER_SKIP_DOWNLOAD: ${{ true }}

jobs:
# Verifies that installing npm dependencies and building WordPress works as expected.
#
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -100,4 +100,4 @@ wp-tests-config.php
/docker-compose.override.yml

# Visual regression test diffs
tests/visual-regression/specs/__image_snapshots__
tests/visual-regression/specs/__snapshots__
Loading