Skip to content

Patterns: Don't inject theme attr on frontend #5455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ockham wants to merge 10 commits into from
Closed

Patterns: Don't inject theme attr on frontend #5455

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
909ec6b
Patterns: Don't inject theme attr on frontend
ockham Oct 10, 2023
8fb2f79
Remove _inject_theme_attribute_in_template_part_block() and all its u…
felixarntz Oct 11, 2023
9751e1c
Revert "Remove _inject_theme_attribute_in_template_part_block() and a…
felixarntz Oct 11, 2023
9315aa3
Only call _inject_theme_attribute_in_template_part_block() if a REST …
felixarntz Oct 11, 2023
5932fba
Only call _inject_theme_attribute_in_template_part_block() if a REST …
felixarntz Oct 11, 2023
5c27373
Avoid duplicate code.
felixarntz Oct 11, 2023
44d7eab
Remove tests which are no longer applicable.
felixarntz Oct 11, 2023
14f6306
Implement test coverage to ensure template part block works correctly…
felixarntz Oct 11, 2023
2af8248
Use `!== null` equality checks
ockham Oct 12, 2023
17ca37a
Use `!== null` equality checks once more
ockham Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Only call _inject_theme_attribute_in_template_part_block() if a REST … 
…API request.
  • Loading branch information
@felixarntz @ockham
felixarntz authored and ockham committed Oct 12, 2023
commit 5932fba0299d1ebf2fd7fecbbb44615805573cf1
9 changes: 6 additions & 3 deletions src/wp-includes/block-template-utils.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -549,15 +549,18 @@ function _build_block_template_result_from_file( $template_file, $template_type
$template->area = $template_file['area'];
}

$before_block_visitor = '_inject_theme_attribute_in_template_part_block';
$before_block_visitor = ( defined( 'REST_REQUEST' ) && REST_REQUEST ) ? '_inject_theme_attribute_in_template_part_block' : null;
$after_block_visitor = null;
$hooked_blocks = get_hooked_blocks();
if ( ! empty( $hooked_blocks ) || has_filter( 'hooked_block_types' ) ) {
$before_block_visitor = make_before_block_visitor( $hooked_blocks, $template );
$after_block_visitor = make_after_block_visitor( $hooked_blocks, $template );
}
$blocks = parse_blocks( $template_content );
$template->content = traverse_and_serialize_blocks( $blocks, $before_block_visitor, $after_block_visitor );
if ( ! is_null( $before_block_visitor ) || ! is_null( $after_block_visitor ) ) {
$blocks = parse_blocks( $template_content );
$template_content = traverse_and_serialize_blocks( $blocks, $before_block_visitor, $after_block_visitor );
}
$template->content = $template_content;

return $template;
}
Expand Down